Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2200183005: Only bundle_data asan runtime on mac. (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only bundle_data asan runtime on mac. bundle_data is a noop on Windows, so no behavior change, but a bit nicer. Patch from dpranke@ BUG=598761 Committed: https://crrev.com/640fe86764317ab19f855b06da72ac80c39296d6 Cr-Commit-Position: refs/heads/master@{#409659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M build/config/sanitizers/BUILD.gn View 2 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Nico
4 years, 4 months ago (2016-08-03 21:45:25 UTC) #3
Nico
dpranke, since you seem to be near a computer, want to lg your patch? :-)
4 years, 4 months ago (2016-08-03 22:21:38 UTC) #7
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-03 22:28:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200183005/1
4 years, 4 months ago (2016-08-03 23:07:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 23:26:39 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 23:27:42 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/640fe86764317ab19f855b06da72ac80c39296d6
Cr-Commit-Position: refs/heads/master@{#409659}

Powered by Google App Engine
This is Rietveld 408576698