Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc

Issue 2200113002: [New CL] Add a tab helper to record the last visit date for each bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary explicit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2fd01957986b9a85624f3b36041674331eae7b7d
--- /dev/null
+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
@@ -0,0 +1,120 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h"
+
+#include <algorithm>
+#include <string>
+#include <utility>
+
+#include "base/strings/string_number_conversions.h"
+#include "base/time/time.h"
+#include "components/bookmarks/browser/bookmark_model.h"
+#include "components/bookmarks/browser/bookmark_node.h"
+#include "url/gurl.h"
+
+using bookmarks::BookmarkModel;
+using bookmarks::BookmarkNode;
+
+namespace ntp_snippets {
+
+namespace {
+
+const char kBookmarkLastVisitDateKey[] = "last_visited";
+
+base::Time ParseLastVisitDate(const std::string& date_string) {
+ int64_t date = 0;
+ if (!base::StringToInt64(date_string, &date))
+ return base::Time::UnixEpoch();
+ return base::Time::FromInternalValue(date);
+}
+
+std::string FormatLastVisitDate(const base::Time& date) {
+ return base::Int64ToString(date.ToInternalValue());
+}
+
+bool CompareBookmarksByLastVisitDate(const BookmarkNode* a,
+ const BookmarkNode* b) {
+ return GetLastVisitDateForBookmark(a) > GetLastVisitDateForBookmark(b);
+}
+
+} // namespace
+
+void UpdateBookmarkOnURLVisitedInMainFrame(BookmarkModel* bookmark_model,
+ const GURL& url) {
+ std::vector<const BookmarkNode*> bookmarks_for_url;
+ bookmark_model->GetNodesByURL(url, &bookmarks_for_url);
+ if (bookmarks_for_url.empty())
+ return;
+
+ // If there are bookmarks for |url|, set their last visit date to now.
+ std::string now = FormatLastVisitDate(base::Time::Now());
+ for (auto* node : bookmarks_for_url) {
+ bookmark_model->SetNodeMetaInfo(node, kBookmarkLastVisitDateKey, now);
+ }
+}
+
+base::Time GetLastVisitDateForBookmark(const BookmarkNode* node) {
+ if (!node)
+ return base::Time::UnixEpoch();
+
+ std::string last_visit_date_string;
+ node->GetMetaInfo(kBookmarkLastVisitDateKey, &last_visit_date_string);
+
+ if (last_visit_date_string.empty()) {
+ // Use creation date if no last visit info present.
+ return node->date_added();
+ }
+
+ return ParseLastVisitDate(last_visit_date_string);
+}
+
+std::vector<const BookmarkNode*> GetRecentlyVisitedBookmarks(
+ BookmarkModel* bookmark_model,
+ int max_count,
+ const base::Time& min_visit_time) {
+ // Get all the bookmarks.
+ std::vector<BookmarkModel::URLAndTitle> bookmarks;
+ bookmark_model->GetBookmarks(&bookmarks);
+
+ // Remove bookmarks that have not been visited after |min_visit_time|.
+ bookmarks.erase(
+ std::remove_if(bookmarks.begin(), bookmarks.end(),
+ [&bookmark_model, &min_visit_time](
+ const BookmarkModel::URLAndTitle& bookmark) {
+ // Get all bookmarks for the given URL.
+ std::vector<const BookmarkNode*> bookmarks_for_url;
+ bookmark_model->GetNodesByURL(bookmark.url,
+ &bookmarks_for_url);
+
+ // Return false if there is a more recent visit time.
+ for (const auto* node : bookmarks_for_url) {
+ if (GetLastVisitDateForBookmark(node) > min_visit_time)
+ return false;
+ }
+ return true;
+ }),
+ bookmarks.end());
+
+ // Sort the remaining bookmarks by date.
+ std::sort(bookmarks.begin(), bookmarks.end(),
+ [&bookmark_model](const BookmarkModel::URLAndTitle& a,
+ const BookmarkModel::URLAndTitle& b) {
+ return CompareBookmarksByLastVisitDate(
+ bookmark_model->GetMostRecentlyAddedUserNodeForURL(a.url),
+ bookmark_model->GetMostRecentlyAddedUserNodeForURL(b.url));
+ });
+
+ // Insert the first |max_count| items from |bookmarks| into |result|.
+ std::vector<const BookmarkNode*> result;
+ for (const BookmarkModel::URLAndTitle& bookmark : bookmarks) {
+ result.push_back(
+ bookmark_model->GetMostRecentlyAddedUserNodeForURL(bookmark.url));
+ if (result.size() >= static_cast<size_t>(max_count))
+ break;
+ }
+ return result;
+}
+
+} // namespace ntp_snippets
« no previous file with comments | « components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698