[New CL] Add a tab helper to record the last visit date for each bookmark

chrome/browser/ntp_snippets/bookmark_last_visit_updater.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ntp_snippets/bookmark_last_visit_updater.h"
+
+#include "components/bookmarks/browser/bookmark_model.h"

[Marc Treib, 2016/08/02 13:37:11]

This isn't strictly required, since you're not doing anything with the
BookmarkModel.

[Philipp Keck, 2016/08/02 14:06:51]

Done.

+#include "components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h"
+#include "content/public/browser/navigation_handle.h"
+
+DEFINE_WEB_CONTENTS_USER_DATA_KEY(BookmarkLastVisitUpdater);
+
+BookmarkLastVisitUpdater::~BookmarkLastVisitUpdater() {}
+
+// static
+void BookmarkLastVisitUpdater::CreateForWebContentsWithBookmarkModel(
+    content::WebContents* web_contents,
+    bookmarks::BookmarkModel* bookmark_model) {
+  DCHECK(web_contents);

[Marc Treib, 2016/08/02 13:37:11]

This is superfluous - if it were null, we'd crash in the next line anyway, and
it doesn't provide any information to the reader since the next line obviously
assumes it's non-null.

[Philipp Keck, 2016/08/02 14:06:51]

Done.

+  web_contents->SetUserData(UserDataKey(), new BookmarkLastVisitUpdater(
+                                               web_contents, bookmark_model));
+}
+
+BookmarkLastVisitUpdater::BookmarkLastVisitUpdater(
+    content::WebContents* web_contents,
+    bookmarks::BookmarkModel* bookmark_model)
+    : content::WebContentsObserver(web_contents),
+      bookmark_model_(bookmark_model) {}
+
+void BookmarkLastVisitUpdater::DidStartNavigation(
+    content::NavigationHandle* navigation_handle) {
+  if (!navigation_handle->IsInMainFrame() || navigation_handle->IsErrorPage())
+    return;
+  ntp_snippets::UpdateBookmarkOnURLVisitedInMainFrame(
+      bookmark_model_, navigation_handle->GetURL());
+}