chrome/renderer/resources/neterror.html - Issue 22001002: Use the connectivity diagnostics launcher so that it can open as an App

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/neterror.html

Issue 22001002: Use the connectivity diagnostics launcher so that it can open as an App (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix manifest Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/connectivity_diagnostics_launcher/manifest.json ('K') | « chrome/common/extensions/extension_constants.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/neterror.html

diff --git a/chrome/renderer/resources/neterror.html b/chrome/renderer/resources/neterror.html

index 3a9edafeecf8170ac5b13d1b90c222336cb56007..1b2e1894d6bc0d1b7fcb6b7a749b73e44fad2282 100644

--- a/chrome/renderer/resources/neterror.html

+++ b/chrome/renderer/resources/neterror.html

@@ -311,7 +311,10 @@ function toggleHelpBox() {

}

function diagnoseErrors() {

- location = "chrome-extension://kodldpbjkkmmnilagfdheibampofhaom/index.html";

+ var diagnose_frame = document.getElementById('diagnose-frame');

+ diagnose_frame.innerHTML =

+ '<iframe src="chrome-extension://idddmepepmjcgiedknnmlbadcokidhoa/index.html"></iframe>';

Dmitry Polukhin 2013/08/02 23:17:07 Please keep it 80 chars per line.

}

// Subframes use a different layout but the same html file. This is to make it

@@ -364,6 +367,7 @@ document.addEventListener("DOMContentLoaded", swapButtonOrder);

</div>

<button id="diagnose-button" onclick="diagnoseErrors()"

jscontent="diagnose" jsdisplay="diagnose"></button>

+ <div id="diagnose-frame" class="hidden"></div>

</div>

« chrome/browser/resources/chromeos/connectivity_diagnostics_launcher/manifest.json ('K') | « chrome/common/extensions/extension_constants.cc ('k') | no next file » | no next file with comments »