Issue 220010: Store non-standard HTTP headers in history. (WebKit side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 220010: Store non-standard HTTP headers in history. (WebKit side)

Created:
11 years, 3 months ago by Marshall Greenblatt

Modified:
11 years, 3 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://svn.webkit.org/repository/webkit/trunk/WebCore/

Visibility:
Public.

Description

We currently have the ability to set extra HTTP header fields in WebURLRequest. However, the extra HTTP header fields are not stored in WebHistoryItem and are therefore lost after navigation. Non-standard HTTP headers, usually prefixed with 'X-', are used by a number of server-based applications and represent a safe subset of extra HTTP headers that can be stored in the history. This patch works in combination with the patch for the below WebKit issue to support storage and recall of non-standard HTTP headers. https://bugs.webkit.org/show_bug.cgi?id=26994 The chromium side of this patch is available here: http://codereview.chromium.org/225012

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -1 line)			Patch
M	history/HistoryItem.h	View	1 2 3	5 chunks	+8 lines, -0 lines	0 comments	Download
M	history/HistoryItem.cpp	View	1 2 3	1 chunk	+59 lines, -1 line	0 comments	Download
M	loader/FrameLoader.cpp	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Please review this patch.

Expand Messages | Collapse Messages

Issue 220010: Store non-standard HTTP headers in history. (WebKit side)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages