Chromium Code Reviews
Help | Chromium Project | Sign in
(1153)

Issue 220009: Provides a certificate for SSL client authentication on NSS sockets.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by Jaime Soriano
Modified:
2 years, 8 months ago
Reviewers:
mark4porn, wtc
CC:
chromium-reviews_googlegroups.com, darin
Visibility:
Public.

Description

[Replaced by http://codereview.chromium.org/276037 ]

Provides a certificate for SSL client authentication on NSS sockets.
GUI is still missing, so certificates and private keys have to be
stored manually, p.e.:
$ pk12util -d sql:$HOME/.pki/nssdb -i PKCS12_file.p12
Adds --auto-ssl-client-auth command-line option to enable this feature.

BUG=16830
TEST=Try to connect to a web page that requires SSL authentication and confirm that it connects if and only if a valid certificate is stored in .pki/nssdb database.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : '' #

Total comments: 19

Patch Set 4 : '' #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -4 lines) Lint Patch
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 3 2 chunks +9 lines, -0 lines 0 comments 0 errors Download
M chrome/common/chrome_switches.h View 2 3 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M chrome/common/chrome_switches.cc View 2 3 1 chunk +10 lines, -0 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss.h View 1 2 3 3 chunks +13 lines, -0 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss.cc View 1 2 3 8 chunks +123 lines, -4 lines 3 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 17
wtc
Great! I will look at the patch tomorrow or on Monday. (I'm busy today.) Thanks ...
4 years, 6 months ago #1
wtc
I took a quick look. The main issue with your patch is that it does ...
4 years, 6 months ago #2
wtc
http://codereview.chromium.org/220009/diff/6001/7002 File net/socket/ssl_client_socket_nss.cc (right): http://codereview.chromium.org/220009/diff/6001/7002#newcode70 Line 70: #include "chrome/common/chrome_switches.h" The net module can't use functions ...
4 years, 6 months ago #3
wtc
http://codereview.chromium.org/220009/diff/6001/7003 File chrome/common/chrome_switches.h (right): http://codereview.chromium.org/220009/diff/6001/7003#newcode95 Line 95: #if defined(USE_NSS) This test should be #if defined(OS_LINUX) ...
4 years, 6 months ago #4
wtc
http://codereview.chromium.org/220009/diff/6001/7002 File net/socket/ssl_client_socket_nss.cc (right): http://codereview.chromium.org/220009/diff/6001/7002#newcode717 Line 717: status = NSS_GetClientAuthData(NULL, socket, caNames, pRetCert, pRetKey); On ...
4 years, 6 months ago #5
Jaime Soriano
http://codereview.chromium.org/220009/diff/6001/7003 File chrome/common/chrome_switches.h (right): http://codereview.chromium.org/220009/diff/6001/7003#newcode95 Line 95: #if defined(USE_NSS) On 2009/09/25 16:01:07, wtc wrote: > ...
4 years, 6 months ago #6
Jaime Soriano
http://codereview.chromium.org/220009/diff/8004/8006 File net/socket/ssl_client_socket_nss.cc (right): http://codereview.chromium.org/220009/diff/8004/8006#newcode727 Line 727: if (cert && (privkey = PK11_FindKeyByAnyCert(cert, proto_win))) { ...
4 years, 6 months ago #7
wtc
I will try to take a look at this tomorrow. I have been swamped with ...
4 years, 6 months ago #8
Jaime Soriano
On 2009/10/07 02:41:09, wtc wrote: > I will try to take a look at this ...
4 years, 6 months ago #9
Jaime Soriano
http://codereview.chromium.org/220009/diff/8004/8006 File net/socket/ssl_client_socket_nss.cc (right): http://codereview.chromium.org/220009/diff/8004/8006#newcode759 Line 759: if ( PK11_FindKeyByAnyCert(cert, proto_win) ) { This key ...
4 years, 6 months ago #10
wtc
Jaime, Finally I was able to spend some time on this changelist this afternoon. I ...
4 years, 6 months ago #11
Jaime Soriano
On 2009/10/10 00:13:34, wtc wrote: > I edited the description of your CL slightly. One ...
4 years, 6 months ago #12
Jaime Soriano
http://codereview.chromium.org/220009/diff/8004/8009 File chrome/browser/renderer_host/resource_dispatcher_host.cc (right): http://codereview.chromium.org/220009/diff/8004/8009#newcode1060 Line 1060: #else On 2009/10/10 00:13:34, wtc wrote: > The ...
4 years, 6 months ago #13
Jaime Soriano
I didn't manage to change the way I do the handshake renegotiation. http://codereview.chromium.org/220009/diff/18001/19002 File net/socket/ssl_client_socket_nss.cc ...
4 years, 6 months ago #14
wtc
Jaime, Thanks for the new Patch Set. I didn't have time to review it today. ...
4 years, 6 months ago #15
wtc
Jaime, I have started to review your new patch set. It has been moved to ...
4 years, 6 months ago #16
mark4porn
2 years, 8 months ago #17
ncluded in the email sent (if any).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6