Provides a certificate for SSL client authentication on NSS sockets....

net/socket/ssl_client_socket_nss.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file includes code GetDefaultCertNickname(), derived from
 // nsNSSCertificate::defaultServerNickName()
 // in mozilla/security/manager/ssl/src/nsNSSCertificate.cpp
 // and SSLClientSocketNSS::DoVerifyCertComplete() derived from
 // AuthCertificateCallback() in
 // mozilla/security/manager/ssl/src/nsNSSCallbacks.cpp.
@@ skipping 33 matching lines @@
  * decision by deleting the provisions above and replace them with the notice
  * and other provisions required by the GPL or the LGPL. If you do not delete
  * the provisions above, a recipient may use your version of this file under
  * the terms of any one of the MPL, the GPL or the LGPL.
  *
  * ***** END LICENSE BLOCK ***** */
 
 #include "net/socket/ssl_client_socket_nss.h"
 
 #include <certdb.h>
+#include <key.h>
 #include <nspr.h>
 #include <nss.h>
 #include <secerr.h>
 // Work around https://bugzilla.mozilla.org/show_bug.cgi?id=455424
 // until NSS 3.12.2 comes out and we update to it.
 #define Lock FOO_NSS_Lock
 #include <ssl.h>
 #include <sslerr.h>
 #include <pk11pub.h>
 #undef Lock
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/nss_init.h"
 #include "base/string_util.h"
 #include "net/base/cert_verifier.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
+#include "net/base/ssl_cert_request_info.h"
 #include "net/base/ssl_info.h"
 #include "net/ocsp/nss_ocsp.h"
 
 static const int kRecvBufferSize = 4096;
 
 namespace net {
 
 // State machines are easier to debug if you log state transitions.
 // Enable these if you want to see what's going on.
 #if 1
@@ skipping 111 matching lines @@
       buffer_recv_callback_(this, &SSLClientSocketNSS::BufferRecvComplete),
       transport_send_busy_(false),
       transport_recv_busy_(false),
       io_callback_(this, &SSLClientSocketNSS::OnIOComplete),
       transport_(transport_socket),
       hostname_(hostname),
       ssl_config_(ssl_config),
       user_connect_callback_(NULL),
       user_callback_(NULL),
       user_buf_len_(0),
+      client_auth_ca_names_(NULL),
+      client_auth_cert_needed_(false),
       completed_handshake_(false),
       next_state_(STATE_NONE),
       nss_fd_(NULL),
       nss_bufs_(NULL) {
   EnterFunction("");
 }
 
 SSLClientSocketNSS::~SSLClientSocketNSS() {
   EnterFunction("");
   Disconnect();
@@ skipping 91 matching lines @@
 #endif
 
   rv = SSL_OptionSet(nss_fd_, SSL_HANDSHAKE_AS_CLIENT, PR_TRUE);
   if (rv != SECSuccess)
      return ERR_UNEXPECTED;
 
   rv = SSL_AuthCertificateHook(nss_fd_, OwnAuthCertHandler, this);
   if (rv != SECSuccess)
      return ERR_UNEXPECTED;
 
+  rv = SSL_GetClientAuthDataHook(nss_fd_, ClientAuthHandler, this);
+  if (rv != SECSuccess)
+     return ERR_UNEXPECTED;
+
   rv = SSL_HandshakeCallback(nss_fd_, HandshakeCallback, this);
   if (rv != SECSuccess)
     return ERR_UNEXPECTED;
 
   // Tell SSL the hostname we're trying to connect to.
   SSL_SetURL(nss_fd_, hostname_.c_str());
 
   // Tell SSL we're a client; needed if not letting NSPR do socket I/O
   SSL_ResetHandshake(nss_fd_, 0);
 
@@ skipping 32 matching lines @@
   transport_send_busy_   = false;
   transport_recv_busy_   = false;
   user_connect_callback_ = NULL;
   user_callback_         = NULL;
   user_buf_              = NULL;
   user_buf_len_          = 0;
   server_cert_           = NULL;
   server_cert_verify_result_.Reset();
   completed_handshake_   = false;
   nss_bufs_              = NULL;
+  client_auth_ca_names_  = NULL;

[Jaime Soriano, 2009/10/13 11:13:39]

If client_auth_ca_names_ is freed here with CERT_FreeDistNames, something fails
later double-freeing it.

+  client_auth_cert_needed_ = false;
 
   LeaveFunction("");
 }
 
 bool SSLClientSocketNSS::IsConnected() const {
   // Ideally, we should also check if we have received the close_notify alert
   // message from the server, and return false in that case.  We're not doing
   // that, so this function may return a false positive.  Since the upper
   // layer (HttpNetworkTransaction) needs to handle a persistent connection
   // closed by the server when we send a request anyway, a false positive in
@@ skipping 105 matching lines @@
     UpdateServerCert();
   }
   ssl_info->cert_status = server_cert_verify_result_.cert_status;
   DCHECK(server_cert_ != NULL);
   ssl_info->cert = server_cert_;
   LeaveFunction("");
 }
 
 void SSLClientSocketNSS::GetSSLCertRequestInfo(
     SSLCertRequestInfo* cert_request_info) {
-  // TODO(wtc): implement this.
+  CERTCertNicknames *names;
+  void *wincx = NULL;
+  CERTCertificate* cert = NULL;
+  X509Certificate* x509_cert = NULL;
+  SECKEYPrivateKey* privkey = NULL;
+  EnterFunction("");
+
+  cert_request_info->host_and_port = hostname_;
+  cert_request_info->client_certs.clear();
+
+  wincx = SSL_RevealPinArg(nss_fd_);
+
+  names = CERT_GetCertNicknames(CERT_GetDefaultCertDB(),
+      SEC_CERT_NICKNAMES_USER, wincx);
+
+  if (names != NULL) {
+    for (int i = 0; i < names->numnicknames; i++) {
+      cert = CERT_FindUserCertByUsage(
+          CERT_GetDefaultCertDB(),
+          names->nicknames[i],
+          certUsageSSLClient,
+          PR_FALSE,
+          wincx);
+      if (!cert)
+        continue;
+      // Only check unexpired certs
+      if (CERT_CheckCertValidTimes(cert, PR_Now(), PR_TRUE) !=
+          secCertTimeValid ) {
+         CERT_DestroyCertificate(cert);
+         continue;
+      }
+      if (NSS_CmpCertChainWCANames(cert, client_auth_ca_names_) == SECSuccess) {
+        privkey = PK11_FindKeyByAnyCert(cert, wincx);
+        if (privkey) {
+          x509_cert = X509Certificate::CreateFromHandle(
+            cert, X509Certificate::SOURCE_LONE_CERT_IMPORT);
+          cert_request_info->client_certs.push_back(x509_cert);
+          SECKEY_DestroyPrivateKey(privkey);
+          continue;
+        }
+      }
+      CERT_DestroyCertificate(cert);
+    }
+    CERT_FreeNicknames(names);
+  }
+  LeaveFunction(cert_request_info->client_certs.size());
 }
 
 void SSLClientSocketNSS::DoCallback(int rv) {
   EnterFunction(rv);
   DCHECK(rv != ERR_IO_PENDING);
   DCHECK(user_callback_);
 
   // Since Run may result in Read being called, clear |user_callback_| up front.
   CompletionCallback* c = user_callback_;
   user_callback_ = NULL;
@@ skipping 182 matching lines @@
 // in full handshake mode or in resumption handshake mode.
 SECStatus SSLClientSocketNSS::OwnAuthCertHandler(void* arg,
                                                  PRFileDesc* socket,
                                                  PRBool checksig,
                                                  PRBool is_server) {
   // Tell NSS to not verify the certificate.
   return SECSuccess;
 }
 
 // static
+// NSS calls this if a client certificate is needed.
+// Based on Mozilla's NSS_GetClientAuthData
+SECStatus SSLClientSocketNSS::ClientAuthHandler(
+    void* arg,
+    PRFileDesc* socket,
+    CERTDistNames* ca_names,
+    CERTCertificate** result_certificate,
+    SECKEYPrivateKey** result_private_key) {
+  SSLClientSocketNSS* that = reinterpret_cast<SSLClientSocketNSS*>(arg);
+  CERTCertificate* cert = NULL;
+  SECKEYPrivateKey* privkey = NULL;
+  PRArenaPool* arena = NULL;
+  CERTDistNames* ca_names_copy = NULL;
+  void *wincx = NULL;
+
+  wincx = SSL_RevealPinArg(socket);
+
+  that->client_auth_cert_needed_ = !that->ssl_config_.send_client_cert;
+
+  // Second pass, a client certificate should have been selected
+  if (that->ssl_config_.send_client_cert) {
+    if (that->ssl_config_.client_cert) {
+      cert = CERT_DupCertificate(
+        that->ssl_config_.client_cert->os_cert_handle());
+      if (cert) {
+        privkey = PK11_FindKeyByAnyCert(cert, wincx);
+        if (privkey) {
+          // TODO(jsorianopastor): We should wait for server certificate
+          // verification before sending our credentials.
+          // (http://code.google.com/p/chromium/issues/detail?id=13934)
+          result_certificate[0] = cert;
+          result_private_key[0] = privkey;
+          return SECSuccess;
+        } else {
+          LOG(WARNING) << "Client cert found without private key";
+        }
+      } else {
+        LOG(WARNING) << "Invalid client cert to send";
+      }
+    }
+    // If not, client authentication failed
+    return SECFailure;
+  }
+
+  arena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE);
+  ca_names_copy = PORT_ArenaZNew(arena, CERTDistNames);
+
+  ca_names_copy->arena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE);
+  ca_names_copy->head = NULL;
+  ca_names_copy->nnames = ca_names->nnames;
+  ca_names_copy->names = SECITEM_ArenaDupItem(arena, ca_names->names);
+
+  that->client_auth_ca_names_ = ca_names_copy;

[Jaime Soriano, 2009/10/13 11:13:39]

I'm not sure if this is the correct way to duplicate a CERTDistNames.
It works, but I cannot explicitelly free it.

+  return SECFailure;
+}
+
+// static
 // NSS calls this when handshake is completed.
 // After the SSL handshake is finished, use CertVerifier to verify
 // the saved server certificate.
 void SSLClientSocketNSS::HandshakeCallback(PRFileDesc* socket,
                                            void* arg) {
   SSLClientSocketNSS* that = reinterpret_cast<SSLClientSocketNSS*>(arg);
 
   that->UpdateServerCert();
 }
 
 int SSLClientSocketNSS::DoHandshakeRead() {
   EnterFunction("");
   int net_error = net::OK;
   int rv = SSL_ForceHandshake(nss_fd_);
 
   if (rv == SECSuccess) {
-    // SSL handshake is completed.  Let's verify the certificate.
-    GotoState(STATE_VERIFY_CERT);
-    // Done!
+    if (client_auth_cert_needed_) {
+      net_error = ERR_SSL_CLIENT_AUTH_CERT_NEEDED;
+      if (SECSuccess != SSL_ReHandshake(nss_fd_, PR_TRUE)) {

[Jaime Soriano, 2009/10/13 11:13:39]

I tried to remove this, but then it didn't request the client authentication on
the second pass.
I also tried with this lines by wtc:

+        LOG(WARNING) << "Couldn't restart handshake: " << PR_GetError();
+      }
+    } else {
+      // SSL handshake is completed.  Let's verify the certificate.
+      GotoState(STATE_VERIFY_CERT);
+      // Done!
+    }
   } else {
     PRErrorCode prerr = PR_GetError();
 
     // If the server closed on us, it is a protocol error.
     // Some TLS-intolerant servers do this when we request TLS.
     if (prerr == PR_END_OF_FILE_ERROR) {
       net_error = ERR_SSL_PROTOCOL_ERROR;
     } else {
       net_error = NetErrorFromNSPRError(prerr);
     }
@@ skipping 120 matching lines @@
   if (prerr == PR_WOULD_BLOCK_ERROR) {
     GotoState(STATE_PAYLOAD_WRITE);
     return ERR_IO_PENDING;
   }
   user_buf_ = NULL;
   LeaveFunction("");
   return NetErrorFromNSPRError(prerr);
 }
 
 }  // namespace net