third_party/WebKit/Source/core/style/ComputedStyleConstants.h - Issue 2200053002: Add TypeTraits template for checking safe bitfields (WIP)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyleConstants.h

Issue 2200053002: Add TypeTraits template for checking safe bitfields (WIP) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_visibility_enum_class_rebase

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/style/ComputedStyleConstants.h

diff --git a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h

index 57a6689f7b3b1b5c61f96e982493218bdd35458e..31d3040d7c9bb1c30f0ffb80e56d559a2511c1b9 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h

+++ b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h

@@ -391,8 +391,6 @@ enum ECaptionSide {

enum EListStylePosition { ListStylePositionOutside, ListStylePositionInside };

-// TODO(sashab): Add a static_assert when this is used in bitfields to ensure it

-// uses unsigned as the underlying type.

enum class EVisibility : unsigned { Visible, Hidden, Collapse };

enum ECursor {

« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/wtf/TypeTraits.h » ('j') | no next file with comments »