Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/PRESUBMIT.py

Issue 2200003002: Automatically trigger spv2 tryjobs on paint-related changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup style Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/PRESUBMIT.py
diff --git a/third_party/WebKit/PRESUBMIT.py b/third_party/WebKit/PRESUBMIT.py
index cee4638e6e81de47436fa975eb0c69f3a02cc65c..c252d5ea67ef99080c7d99d13ae6c4901e7983df 100644
--- a/third_party/WebKit/PRESUBMIT.py
+++ b/third_party/WebKit/PRESUBMIT.py
@@ -8,6 +8,7 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into gcl.
"""
+import os
import re
import sys
@@ -320,3 +321,55 @@ def CheckChangeOnCommit(input_api, output_api):
results.extend(input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api))
return results
+
+
+def _ArePaintOrCompositingDirectoriesModified(change): # pylint: disable=C0103
+ """Checks whether CL has changes to paint or compositing directories."""
+ paint_or_compositing_paths = [
+ os.path.join('third_party', 'WebKit', 'Source', 'platform', 'graphics',
+ 'compositing'),
+ os.path.join('third_party', 'WebKit', 'Source', 'platform', 'graphics',
+ 'paint'),
+ os.path.join('third_party', 'WebKit', 'Source', 'core', 'layout',
+ 'compositing'),
+ os.path.join('third_party', 'WebKit', 'Source', 'core', 'paint'),
+ ]
+ for affected_file in change.AffectedFiles():
+ file_path = affected_file.LocalPath()
+ if any(x in file_path for x in paint_or_compositing_paths):
+ return True
+ return False
+
+
+def PostUploadHook(cl, change, output_api): # pylint: disable=C0103
+ """git cl upload will call this hook after the issue is created/modified.
+
+ This hook adds extra try bots to the CL description in order to run slimming
+ paint v2 tests in addition to the CQ try bots if the change contains paint
+ or compositing changes (see: _ArePaintOrCompositingDirectoriesModified). For
+ more information about slimming-paint-v2 tests see https://crbug.com/601275.
+ """
+ if not _ArePaintOrCompositingDirectoriesModified(change):
+ return []
+
+ rietveld_obj = cl.RpcServer()
+ issue = cl.issue
+ description = rietveld_obj.get_description(issue)
+ if re.search(r'^CQ_INCLUDE_TRYBOTS=.*', description, re.M | re.I):
+ return []
+
+ bots = [
+ 'master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2',
+ ]
+
+ results = []
+ new_description = description
+ new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots)
+ results.append(output_api.PresubmitNotifyResult(
+ 'Automatically added slimming-paint-v2 tests to run on CQ due to '
+ 'changes in paint or compositing directories.'))
+
+ if new_description != description:
+ rietveld_obj.update_description(issue, new_description)
+
+ return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698