Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2199983002: Also attempt to symbolize dart frames in Profiler::DumpStackTrace. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Also attempt to symbolize dart frames in Profiler::DumpStackTrace. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/d215693513f883e3c59a97daacca01b1048d4820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M runtime/vm/profiler.cc View 2 chunks +31 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
Output looks like Dumping native stack trace for thread 5d68 00000000008b2ca6 [native] dart::Profiler::DumpStackTrace(bool) 00000000008b2ca6 [native] ...
4 years, 4 months ago (2016-08-01 21:40:31 UTC) #2
Cutch
lgtm
4 years, 4 months ago (2016-08-01 22:16:40 UTC) #3
rmacnak
4 years, 4 months ago (2016-08-02 00:58:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d215693513f883e3c59a97daacca01b1048d4820 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698