chromecast/android/cast_jni_registrar.cc - Issue 2199973003: Android JNI gen: Don't emit code for empty RegisterNatives()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/android/cast_jni_registrar.cc

Issue 2199973003: Android JNI gen: Don't emit code for empty RegisterNatives() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jnireg1

Patch Set: Android JNI gen: Don't emit code for empty RegisterNatives() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/jni_generator/testNativeExportsOnlyOption.golden ('k') | chromecast/base/android/dumpstate_writer.h » ('j') | chromecast/base/cast_sys_info_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/android/cast_jni_registrar.cc

diff --git a/chromecast/android/cast_jni_registrar.cc b/chromecast/android/cast_jni_registrar.cc

index eccbf0006ecbabbe30b654a1e4a4af84cbf39cc0..90a487ef8f239e5c5c9f87e2137ed84d4e63b736 100644

--- a/chromecast/android/cast_jni_registrar.cc

+++ b/chromecast/android/cast_jni_registrar.cc

@@ -9,9 +9,7 @@

#include "base/macros.h"

#include "chromecast/android/cast_metrics_helper_android.h"

#include "chromecast/app/android/crash_handler.h"

-#include "chromecast/base/android/dumpstate_writer.h"

#include "chromecast/base/android/system_time_change_notifier_android.h"

-#include "chromecast/base/cast_sys_info_android.h"

#include "chromecast/base/chromecast_config_android.h"

#include "chromecast/browser/android/cast_window_android.h"

#include "chromecast/browser/android/cast_window_manager.h"

@@ -24,12 +22,10 @@ namespace {

static base::android::RegistrationMethod kMethods[] = {

{ "CastMetricsHelperAndroid", CastMetricsHelperAndroid::RegisterJni },

- { "CastSysInfoAndroid", CastSysInfoAndroid::RegisterJni },

{ "CastWindowAndroid", shell::CastWindowAndroid::RegisterJni },

{ "CastWindowManager", shell::RegisterCastWindowManager },

{ "ChromecastConfigAndroid", ChromecastConfigAndroid::RegisterJni },

{ "CrashHandler", CrashHandler::RegisterCastCrashJni },

- { "DumpstateWriter", DumpstateWriter::RegisterJni },

{ "ExternalVideoSurfaceContainer",

external_video_surface::RegisterExternalVideoSurfaceJni },

{ "SystemTimeChangeNotifierAndroid",