base/android/jni_generator/testNativeExportsOnlyOption.golden - Issue 2199973003: Android JNI gen: Don't emit code for empty RegisterNatives()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/testNativeExportsOnlyOption.golden

Issue 2199973003: Android JNI gen: Don't emit code for empty RegisterNatives() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jnireg1

Patch Set: Android JNI gen: Don't emit code for empty RegisterNatives() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/android/jni_generator/testNativeExportsOnlyOption.golden

diff --git a/base/android/jni_generator/testNativeExportsOnlyOption.golden b/base/android/jni_generator/testNativeExportsOnlyOption.golden

index 067e71076512a080956060c44db2987b238fc36d..97ef05705566db665744be24096faa028dc868f9 100644

--- a/base/android/jni_generator/testNativeExportsOnlyOption.golden

+++ b/base/android/jni_generator/testNativeExportsOnlyOption.golden

@@ -190,10 +190,4 @@ static_cast<jstring>(env->CallStaticObjectMethod(SampleForTests_clazz(env),

// Step 3: RegisterNatives.

-static bool RegisterNativesImpl(JNIEnv* env) __attribute__((unused));

-static bool RegisterNativesImpl(JNIEnv* env) {

- return true;

#endif // org_chromium_example_jni_generator_SampleForTests_JNI

« no previous file with comments | « base/android/jni_generator/testFromJavaPGenerics.golden ('k') | chromecast/android/cast_jni_registrar.cc » ('j') | no next file with comments »