base/android/jni_generator/testFromJavaP.golden - Issue 2199973003: Android JNI gen: Don't emit code for empty RegisterNatives()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/testFromJavaP.golden

Issue 2199973003: Android JNI gen: Don't emit code for empty RegisterNatives() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jnireg1

Patch Set: Android JNI gen: Don't emit code for empty RegisterNatives() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/jni_generator/testConstantsFromJavaP.golden ('k') | base/android/jni_generator/testFromJavaPGenerics.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/jni_generator/testFromJavaP.golden

diff --git a/base/android/jni_generator/testFromJavaP.golden b/base/android/jni_generator/testFromJavaP.golden

index f83c4f4c7e67c99d9e31b90de5c0f282403830d2..18e10820b5cf1bffa22e2b5e319b0d3b84559130 100644

--- a/base/android/jni_generator/testFromJavaP.golden

+++ b/base/android/jni_generator/testFromJavaP.golden

@@ -243,13 +243,6 @@ static ScopedJavaLocalRef<jobject> Java_InputStream_Constructor(JNIEnv* env) {

// Step 3: RegisterNatives.

-static bool RegisterNativesImpl(JNIEnv* env) __attribute__((unused));

-static bool RegisterNativesImpl(JNIEnv* env) {

- if (base::android::IsManualJniRegistrationDisabled()) return true;

- return true;

} // namespace JNI_InputStream

#endif // java_io_InputStream_JNI