base/android/jni_generator/testCalledByNatives.golden - Issue 2199973003: Android JNI gen: Don't emit code for empty RegisterNatives()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/testCalledByNatives.golden

Issue 2199973003: Android JNI gen: Don't emit code for empty RegisterNatives() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jnireg1

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/jni_generator/jni_generator.py ('K') | « base/android/jni_generator/jni_generator.py ('k') | base/android/jni_generator/testConstantsFromJavaP.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/jni_generator/testCalledByNatives.golden

diff --git a/base/android/jni_generator/testCalledByNatives.golden b/base/android/jni_generator/testCalledByNatives.golden

index ab2b35c5141d7978ff11c083d7cfe217d1439dea..c3c2eef66aa4348498c4a78f082bd4aa1e16b7e4 100644

--- a/base/android/jni_generator/testCalledByNatives.golden

+++ b/base/android/jni_generator/testCalledByNatives.golden

@@ -475,13 +475,4 @@ static ScopedJavaLocalRef<jobject> Java_TestJni_getCompressFormatList(JNIEnv*

return ScopedJavaLocalRef<jobject>(env, ret);

}

-// Step 3: RegisterNatives.

-static bool RegisterNativesImpl(JNIEnv* env) __attribute__((unused));

-static bool RegisterNativesImpl(JNIEnv* env) {

- if (base::android::IsManualJniRegistrationDisabled()) return true;

- return true;

#endif // org_chromium_TestJni_JNI