Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2199973002: Rename FontConfigInterface font manager files. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename FontConfigInterface font manager files. These files are now so badly misnamed that it is causing problems. The original files are kept as shells until Chromium and PDFium can be updated. After Chromium and PDFium builds are updated, the old files will be removed and the cmake and bzl builds will be updated. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199973002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/7d0e3bc785fc5aaf2ed0aa8f37a2bc85c2f82da0

Patch Set 1 #

Patch Set 2 : All the build systems. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -288 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M cmake/CMakeLists.txt View 1 1 chunk +3 lines, -1 line 0 comments Download
M gyp/ports.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M public.bzl View 1 6 chunks +4 lines, -6 lines 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -246 lines 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 1 chunk +1 line, -37 lines 0 comments Download
A + src/ports/SkFontMgr_FontConfigInterface.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/ports/SkFontMgr_FontConfigInterface_factory.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
bungeman-skia
4 years, 4 months ago (2016-08-01 22:18:11 UTC) #14
mtklein
lgtm
4 years, 4 months ago (2016-08-01 22:22:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199973002/20001
4 years, 4 months ago (2016-08-02 14:06:38 UTC) #20
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 4 months ago (2016-08-02 14:06:40 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 14:07:36 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7d0e3bc785fc5aaf2ed0aa8f37a2bc85c2f82da0

Powered by Google App Engine
This is Rietveld 408576698