Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2199943003:
Add TaskScheduler::CreateAndSetDefaultTaskScheduler (Closed)
|
Created:
4 years, 4 months ago by robliao Modified:
4 years, 4 months ago CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@public Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd TaskScheduler::CreateAndSetDefaultTaskScheduler
BUG=553459
Committed: https://crrev.com/d2ab1f7d9311ded2200a624f4d417014a8f35815
Cr-Commit-Position: refs/heads/master@{#409319}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Update Comments #
Depends on Patchset: Messages
Total messages: 30 (23 generated)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
robliao@chromium.org changed reviewers: + fdoray@chromium.org, gab@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm w/ comments https://codereview.chromium.org/2199943003/diff/40001/base/task_scheduler/tas... File base/task_scheduler/task_scheduler.h (right): https://codereview.chromium.org/2199943003/diff/40001/base/task_scheduler/tas... base/task_scheduler/task_scheduler.h:59: Maybe write a comment that applies to both CreateAndSetDefaultTaskScheduler and SetInstance, and then have simpler comments that explain the particularities of each method? Or explicitly say that this method calls SetInstance? See https://chromium.googlesource.com/chromium/src/+/67ecfb55741b310db7758a594ca1... https://codereview.chromium.org/2199943003/diff/40001/base/task_scheduler/tas... base/task_scheduler/task_scheduler.h:78: // Retrieve the TaskScheduler set via SetInstance(). This should be used very via SetInstance() or CreateAndSetDefaultTaskScheduler()
https://codereview.chromium.org/2199943003/diff/40001/base/task_scheduler/tas... File base/task_scheduler/task_scheduler.h (right): https://codereview.chromium.org/2199943003/diff/40001/base/task_scheduler/tas... base/task_scheduler/task_scheduler.h:59: On 2016/08/02 15:01:29, fdoray wrote: > Maybe write a comment that applies to both CreateAndSetDefaultTaskScheduler and > SetInstance, and then have simpler comments that explain the particularities of > each method? Or explicitly say that this method calls SetInstance? > > See > https://chromium.googlesource.com/chromium/src/+/67ecfb55741b310db7758a594ca1... Done. https://codereview.chromium.org/2199943003/diff/40001/base/task_scheduler/tas... base/task_scheduler/task_scheduler.h:78: // Retrieve the TaskScheduler set via SetInstance(). This should be used very On 2016/08/02 15:01:29, fdoray wrote: > via SetInstance() or CreateAndSetDefaultTaskScheduler() Done.
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robliao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org, fdoray@chromium.org Link to the patchset: https://codereview.chromium.org/2199943003/#ps60001 (title: "Update Comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add TaskScheduler::CreateAndSetDefaultTaskScheduler BUG=553459 ========== to ========== Add TaskScheduler::CreateAndSetDefaultTaskScheduler BUG=553459 Committed: https://crrev.com/d2ab1f7d9311ded2200a624f4d417014a8f35815 Cr-Commit-Position: refs/heads/master@{#409319} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d2ab1f7d9311ded2200a624f4d417014a8f35815 Cr-Commit-Position: refs/heads/master@{#409319} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
