Source/core/dom/ContainerNode.cpp - Issue 219993002: Avoid calling markAncestorsWithChildNeedsStyleRecalc() constantly in childrenChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.cpp

Issue 219993002: Avoid calling markAncestorsWithChildNeedsStyleRecalc() constantly in childrenChanged (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix accessibility test and causing recalcs on removal Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ContainerNode.cpp

diff --git a/Source/core/dom/ContainerNode.cpp b/Source/core/dom/ContainerNode.cpp

index 61844795578ee623285e05ca14805c17cc34d2cf..69cc8be79b8865dc4639b3a96b13c38bbd0039fe 100644

--- a/Source/core/dom/ContainerNode.cpp

+++ b/Source/core/dom/ContainerNode.cpp

@@ -654,7 +654,7 @@ void ContainerNode::childrenChanged(bool changedByParser, Node*, Node*, int chil

if (!changedByParser && childCountDelta)

document().updateRangesAfterChildrenChanged(this);

invalidateNodeListCachesInAncestors();

- if (childCountDelta > 0 && inActiveDocument()) {

+ if (childCountDelta > 0 && !childNeedsStyleRecalc()) {

setChildNeedsStyleRecalc();

markAncestorsWithChildNeedsStyleRecalc();

}

« no previous file with comments | « LayoutTests/http/tests/accessibility/slow-document-load.html ('k') | Source/core/dom/Document.h » ('j') | Source/core/dom/Node.cpp » ('J')