Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: media/base/demuxer_stream.h

Issue 2199913002: Notify demux stream clients when a stream is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass stream enabled/disabled flag into StatusChangeCB Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/demuxer_stream.h
diff --git a/media/base/demuxer_stream.h b/media/base/demuxer_stream.h
index 17f193f24acb06c420bd3f00f674da55778dd24f..a2e6c55ec7da1bbf771dd36c8475c5175674bd2a 100644
--- a/media/base/demuxer_stream.h
+++ b/media/base/demuxer_stream.h
@@ -102,9 +102,14 @@ class MEDIA_EXPORT DemuxerStream {
// reading data from a key frame preceeding the |timestamp|.
virtual void set_enabled(bool enabled, base::TimeDelta timestamp) = 0;
- using StreamRestartedCB =
- base::Callback<void(DemuxerStream*, base::TimeDelta)>;
- virtual void SetStreamRestartedCB(const StreamRestartedCB& cb) = 0;
+ // The StreamStatusChangeCB allows DemuxerStream clients to receive
+ // notifications about the stream being disabled or enabled.
+ // The first parameter is the DemuxerStream whose status has changed.
+ // The second parameter indicates whether the stream is enabled or disabled.
+ // The third parameter is the playback position when the change occured.
+ using StreamStatusChangeCB =
alokp 2016/08/04 19:02:36 nit: is it necessary for the callback to specify t
servolk 2016/08/04 20:31:47 Done.
+ base::Callback<void(DemuxerStream*, bool, base::TimeDelta)>;
+ virtual void SetStreamStatusChangeCB(const StreamStatusChangeCB& cb) = 0;
protected:
// Only allow concrete implementations to get deleted.

Powered by Google App Engine
This is Rietveld 408576698