Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2199903002: Create synthetic FieldElement(s) (don't use non-synthetic ones) for non-synthetic class getters/set… (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create synthetic FieldElement(s) (don't use non-synthetic ones) for non-synthetic class getters/setters. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/edcab027bc1469ff3f0efa20f90376c8ccdd3e32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -49 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 12 chunks +79 lines, -43 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 3 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-01 18:44:50 UTC) #1
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-01 18:54:45 UTC) #2
scheglov
4 years, 4 months ago (2016-08-01 19:01:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
edcab027bc1469ff3f0efa20f90376c8ccdd3e32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698