Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: src/objects.cc

Issue 2199863002: Clear recorded slots when making a string external. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: x Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/heap/test-heap.cc » ('j') | test/cctest/heap/test-heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 38deeb825d4b291c707d5e76c1f3cffbf4f1b94a..6ed5f68485b6236bdcba91c90b4c9f447534e88e 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -2093,6 +2093,7 @@ bool String::MakeExternal(v8::String::ExternalOneByteStringResource* resource) {
int new_size = this->SizeFromMap(new_map);
heap->CreateFillerObjectAt(this->address() + new_size, size - new_size,
ClearRecordedSlots::kNo);
+ heap->ClearRecordedSlotRange(this->address(), this->address() + new_size);
// We are storing the new map using release store after creating a filler for
// the left-over space to avoid races with the sweeper thread.
« no previous file with comments | « no previous file | test/cctest/heap/test-heap.cc » ('j') | test/cctest/heap/test-heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698