make an image from a mutable bitmap

make an image from a mutable bitmap

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199813002

Committed: https://skia.googlesource.com/skia/+/2dad769dc9e6a2974c4a7de1ffa945706274fab8

[reed1, 2016-08-01 16:16:38]

Description was changed from

==========
make an image from a mutable bitmap

BUG=skia:
==========

to

==========
make an image from a mutable bitmap

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199813002
==========

[reed1, 2016-08-01 16:16:50]

reed@google.com changed reviewers:
+ djsollen@google.com

[reed1, 2016-08-01 16:16:55]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 16:17:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 16:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 16:40:14]

Dry run: This issue passed the CQ dry run.

[djsollen, 2016-08-01 16:50:14]

lgtm

[reed1, 2016-08-01 16:56:07]

The CQ bit was checked by reed@google.com

[reed1, 2016-08-01 16:56:07]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/2199813002/#ps20001
(title: "add unittest")

[commit-bot: I haz the power, 2016-08-01 16:56:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-08-01 17:14:51]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-08-01 17:14:52]

https://codereview.chromium.org/2199813002/diff/20001/tests/ImageTest.cpp
File tests/ImageTest.cpp (right):

https://codereview.chromium.org/2199813002/diff/20001/tests/ImageTest.cpp#new...
tests/ImageTest.cpp:201: bool          fExpectSameAsMmutable;
:) How many M's in mutable again?

[reed1, 2016-08-01 17:29:09]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-08-01 17:31:10]

https://codereview.chromium.org/2199813002/diff/20001/tests/ImageTest.cpp
File tests/ImageTest.cpp (right):

https://codereview.chromium.org/2199813002/diff/20001/tests/ImageTest.cpp#new...
tests/ImageTest.cpp:201: bool          fExpectSameAsMmutable;
On 2016/08/01 17:14:52, mtklein wrote:
> :) How many M's in mutable again?

Done.

[reed1, 2016-08-01 17:31:14]

The CQ bit was checked by reed@google.com

[reed1, 2016-08-01 17:31:14]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/2199813002/#ps40001
(title: "fixx mmy spilling")

[commit-bot: I haz the power, 2016-08-01 17:31:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 18:13:00]

Description was changed from

==========
make an image from a mutable bitmap

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199813002
==========

to

==========
make an image from a mutable bitmap

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199813002

Committed:
https://skia.googlesource.com/skia/+/2dad769dc9e6a2974c4a7de1ffa945706274fab8
==========

[commit-bot: I haz the power, 2016-08-01 18:13:01]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2dad769dc9e6a2974c4a7de1ffa945706274fab8

[hal.canary, 2016-08-02 13:01:32]

halcanary@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2016-08-02 13:01:33]

If an image wraps a mutable bitmap and the bitmap's generation ID is updated,
does the image's genID change?

[reed1, 2016-08-02 15:26:12]

On 2016/08/02 13:01:33, Hal Canary wrote:
> If an image wraps a mutable bitmap and the bitmap's generation ID is updated,
> does the image's genID change?

Undefined (likely the imageID does not change). This is why this is a
hang-yourself-private-api