third_party/WebKit/Source/web/FullscreenController.cpp - Issue 2199783002: Clarify fullscreenElement vs. currentFullScreenElement distinction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FullscreenController.cpp

Issue 2199783002: Clarify fullscreenElement vs. currentFullScreenElement distinction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/FullscreenController.cpp

diff --git a/third_party/WebKit/Source/web/FullscreenController.cpp b/third_party/WebKit/Source/web/FullscreenController.cpp

index 53c7cbcb2350a480b61090f6c674cbd59eb564a7..cfb4e98039e2a5af7c47d353bcbb349ce269862c 100644

--- a/third_party/WebKit/Source/web/FullscreenController.cpp

+++ b/third_party/WebKit/Source/web/FullscreenController.cpp

@@ -102,7 +102,7 @@ void FullscreenController::didExitFullscreen()

if (Document* document = m_fullScreenFrame->document()) {

if (Fullscreen* fullscreen = Fullscreen::fromIfExists(*document)) {

- Element* element = fullscreen->webkitCurrentFullScreenElement();

+ Element* element = fullscreen->currentFullScreenElement();

if (element) {

// When the client exits from full screen we have to call fullyExitFullscreen to notify

// the document. While doing that, suppress notifications back to the client.