third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp - Issue 2199783002: Clarify fullscreenElement vs. currentFullScreenElement distinction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

Issue 2199783002: Clarify fullscreenElement vs. currentFullScreenElement distinction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

index 1beefc59f081cdc3dd9ed35db85f899fe3199923..bab06a3ff2e55cb5a2b16024b03d35bce556b029 100644

--- a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

@@ -135,7 +135,7 @@ void LayoutTreeBuilderForElement::createLayoutObject()

m_node->setLayoutObject(newLayoutObject);

newLayoutObject->setStyle(&style); // setStyle() can depend on layoutObject() already being set.

- if (Fullscreen::isActiveFullScreenElement(*m_node)) {

+ if (Fullscreen::isCurrentFullScreenElement(*m_node)) {

newLayoutObject = LayoutFullScreen::wrapLayoutObject(newLayoutObject, parentLayoutObject, &m_node->document());

if (!newLayoutObject)

return;

« no previous file with comments | « third_party/WebKit/Source/core/dom/Fullscreen.cpp ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »