headless/lib/browser/headless_browser_impl.cc - Issue 2199773002: headless: make initial screen/window sizes configurable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_browser_impl.cc

Issue 2199773002: headless: make initial screen/window sizes configurable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix constexpr, reference to screen_size in test. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: headless/lib/browser/headless_browser_impl.cc

diff --git a/headless/lib/browser/headless_browser_impl.cc b/headless/lib/browser/headless_browser_impl.cc

index e81e1a3854af728dfd474bbca4997cf68c844d69..8c2096c4757d79191da05cc97062c4f6ea3f58fd 100644

--- a/headless/lib/browser/headless_browser_impl.cc

+++ b/headless/lib/browser/headless_browser_impl.cc

@@ -127,10 +127,8 @@ void HeadlessBrowserImpl::set_browser_main_parts(

void HeadlessBrowserImpl::RunOnStartCallback() {

DCHECK(aura::Env::GetInstance());

- // TODO(eseckler): allow configuration of window (viewport) size by embedder.

- const gfx::Size kDefaultSize(800, 600);

window_tree_host_.reset(

- aura::WindowTreeHost::Create(gfx::Rect(kDefaultSize)));

+ aura::WindowTreeHost::Create(gfx::Rect(options()->window_size)));

window_tree_host_->InitHost();

window_tree_client_.reset(

« no previous file with comments | « no previous file | headless/lib/browser/headless_browser_main_parts.cc » ('j') | no next file with comments »