Add in expiring budget

chrome/browser/budget_service/budget_database_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/budget_service/budget_database.h"
 
 #include "base/run_loop.h"
 #include "base/test/simple_test_clock.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/budget_service/budget.pb.h"
@@ skipping 83 matching lines @@
   BudgetDatabase db_;
   double debt_ = 0;
   BudgetDatabase::BudgetExpectation expectation_;
 };
 
 TEST_F(BudgetDatabaseTest, ReadAndWriteTest) {
   const GURL origin(kTestOrigin);
   base::SimpleTestClock* clock = SetClockForTesting();
   base::TimeDelta expiration(
       base::TimeDelta::FromHours(kDefaultExpirationInHours));
+  base::Time starting_time = clock->Now();
   base::Time expiration_time = clock->Now() + expiration;
 
   // Add two budget chunks with different expirations (default expiration and
   // default expiration + 1 day).
   ASSERT_TRUE(AddBudget(origin, kDefaultBudget1));
   clock->Advance(base::TimeDelta::FromDays(1));
   ASSERT_TRUE(AddBudget(origin, kDefaultBudget2));
 
   // Get the budget.
   GetBudgetDetails();
 
   // Get the expectation and validate it.
   const auto& expected_value = expectation();
   ASSERT_TRUE(success_);
   ASSERT_EQ(3U, expected_value.size());
 
   // Make sure that the correct data is returned.
   auto iter = expected_value.begin();
 
   // First value should be [total_budget, now]
   EXPECT_EQ(kDefaultBudget1 + kDefaultBudget2, iter->first);
-  // TODO(harkness): This will be "now" in the final version. For now, it's
-  // just 0.
-  EXPECT_EQ(0, iter->second);
+  EXPECT_EQ(clock->Now().ToInternalValue(), iter->second);
 
   // The next value should be the budget after the first chunk expires.
   iter++;
   EXPECT_EQ(kDefaultBudget2, iter->first);
   EXPECT_EQ(expiration_time.ToInternalValue(), iter->second);
 
   // The final value gives the budget of 0.0 after the second chunk expires.
   expiration_time += base::TimeDelta::FromDays(1);
   iter++;
   EXPECT_EQ(0, iter->first);
   EXPECT_EQ(expiration_time.ToInternalValue(), iter->second);
+
+  // Advance the time until the first chunk of budget should be expired.
+  clock->SetNow(starting_time +
+                base::TimeDelta::FromHours(kDefaultExpirationInHours));
+
+  // Get the new budget and check that kDefaultBudget1 has been removed.
+  GetBudgetDetails();
+  iter = expectation().begin();

[Peter Beverloo, 2016/08/01 17:35:28]

Please ASSERT() something before this line, if begin() == end() then line 146
will end up accessing something undefined.

(Dito on line 156.)

[harkness, 2016/08/08 14:42:43]

Done.

+  EXPECT_EQ(kDefaultBudget2, iter->first);
+  iter++;
+  EXPECT_EQ(0, iter->first);
+
+  // Advace the time until both chunks of budget should be expired.
+  clock->SetNow(starting_time +
+                base::TimeDelta::FromHours(kDefaultExpirationInHours) +
+                base::TimeDelta::FromDays(1));
+
+  GetBudgetDetails();
+  iter = expectation().begin();
+  EXPECT_EQ(0, iter->first);
 }