Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: src/compiler/access-builder.cc

Issue 2199753002: [turbofan] Inline bunch of ArrayBuffer view accessors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/access-builder.h ('k') | src/compiler/js-builtin-reducer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index 976e051527c1b79a16848c3dc3a4990be170ca9d..1ec6ccf4b50227c61b7cb468ea9e894da6fbb5b0 100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -216,16 +216,14 @@ FieldAccess AccessBuilder::ForJSArrayBufferBackingStore() {
return access;
}
-
// static
FieldAccess AccessBuilder::ForJSArrayBufferBitField() {
- FieldAccess access = {kTaggedBase, JSArrayBuffer::kBitFieldOffset,
- MaybeHandle<Name>(), TypeCache::Get().kInt8,
- MachineType::Int8(), kNoWriteBarrier};
+ FieldAccess access = {kTaggedBase, JSArrayBuffer::kBitFieldOffset,
+ MaybeHandle<Name>(), TypeCache::Get().kUint8,
+ MachineType::Uint32(), kNoWriteBarrier};
return access;
}
-
// static
FieldAccess AccessBuilder::ForJSArrayBufferViewBuffer() {
FieldAccess access = {kTaggedBase,
@@ -237,6 +235,38 @@ FieldAccess AccessBuilder::ForJSArrayBufferViewBuffer() {
return access;
}
+// static
+FieldAccess AccessBuilder::ForJSArrayBufferViewByteLength() {
+ FieldAccess access = {kTaggedBase,
+ JSArrayBufferView::kByteLengthOffset,
+ MaybeHandle<Name>(),
+ TypeCache::Get().kPositiveInteger,
+ MachineType::AnyTagged(),
+ kFullWriteBarrier};
+ return access;
+}
+
+// static
+FieldAccess AccessBuilder::ForJSArrayBufferViewByteOffset() {
+ FieldAccess access = {kTaggedBase,
+ JSArrayBufferView::kByteOffsetOffset,
+ MaybeHandle<Name>(),
+ TypeCache::Get().kPositiveInteger,
+ MachineType::AnyTagged(),
+ kFullWriteBarrier};
+ return access;
+}
+
+// static
+FieldAccess AccessBuilder::ForJSTypedArrayLength() {
+ FieldAccess access = {kTaggedBase,
+ JSTypedArray::kLengthOffset,
+ MaybeHandle<Name>(),
+ TypeCache::Get().kJSTypedArrayLengthType,
+ MachineType::AnyTagged(),
+ kNoWriteBarrier};
+ return access;
+}
// static
FieldAccess AccessBuilder::ForJSDateField(JSDate::FieldIndex index) {
« no previous file with comments | « src/compiler/access-builder.h ('k') | src/compiler/js-builtin-reducer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698