Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2199753002: [turbofan] Inline bunch of ArrayBuffer view accessors. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline bunch of ArrayBuffer view accessors. This adds initial support to inline a couple of the ArrayBuffer view accessors like %TypeArray%.prototype.length and. DataView.prototype.byteLength. R=epertoso@chromium.org Committed: https://crrev.com/a085b8a2c7ae1c95c4b99dda141dc6c51819a0e1 Cr-Commit-Position: refs/heads/master@{#38200}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -8 lines) Patch
M src/compiler/access-builder.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 2 chunks +35 lines, -5 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 5 chunks +102 lines, -3 lines 0 comments Download
M src/compiler/js-graph.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/type-cache.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-01 09:43:36 UTC) #1
epertoso
https://codereview.chromium.org/2199753002/diff/1/src/compiler/js-builtin-reducer.cc File src/compiler/js-builtin-reducer.cc (right): https://codereview.chromium.org/2199753002/diff/1/src/compiler/js-builtin-reducer.cc#newcode681 src/compiler/js-builtin-reducer.cc:681: return dominator; how about return true?
4 years, 4 months ago (2016-08-01 10:27:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199753002/20001
4 years, 4 months ago (2016-08-01 10:32:41 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-01 10:32:43 UTC) #10
Benedikt Meurer
https://codereview.chromium.org/2199753002/diff/1/src/compiler/js-builtin-reducer.cc File src/compiler/js-builtin-reducer.cc (right): https://codereview.chromium.org/2199753002/diff/1/src/compiler/js-builtin-reducer.cc#newcode681 src/compiler/js-builtin-reducer.cc:681: return dominator; On 2016/08/01 10:27:09, epertoso wrote: > how ...
4 years, 4 months ago (2016-08-01 10:32:44 UTC) #11
epertoso
lgtm
4 years, 4 months ago (2016-08-01 10:33:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199753002/20001
4 years, 4 months ago (2016-08-01 10:33:12 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 11:02:50 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 11:05:51 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a085b8a2c7ae1c95c4b99dda141dc6c51819a0e1
Cr-Commit-Position: refs/heads/master@{#38200}

Powered by Google App Engine
This is Rietveld 408576698