Remove some grammar checking code from SpellChecker

Remove some grammar checking code from SpellChecker

This patch does:

1. Remove SpellChecker::markBadGrammar and all of its call sites

2. Absorb SpellChecker::markMisspellingsOrBadGrammar by
SpellChecker::markMisspellings for code simplification

BUG=619452
TEST=n/a; no visible change

Committed: https://crrev.com/9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2
Cr-Commit-Position: refs/heads/master@{#409137}

[Xiaocheng, 2016-08-01 09:42:38]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 09:42:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 11:37:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 11:37:26]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-01 15:13:42]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-01 15:13:43]

PTAL.

[yosin_UTC9, 2016-08-02 01:36:37]

https://codereview.chromium.org/2199743003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2199743003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:430: bool
SpellChecker::markMisspellings(const VisibleSelection& selection)
OPTIONAL: What return |bool| is? Could you add a comment about return value?

https://codereview.chromium.org/2199743003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:432: // This
function is called with a selection already expanded to word boundaries.
nit: Please use |TODO(email): ...| format.

https://codereview.chromium.org/2199743003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:442: const
EphemeralRange range = selection.toNormalizedEphemeralRange();
s/const EphemeralRange/const EphemeralRange&/ to avoid copy.

[Xiaocheng, 2016-08-02 01:51:10]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 01:51:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-02 02:50:38]

Updated.

PTAL.

https://codereview.chromium.org/2199743003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2199743003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:430: bool
SpellChecker::markMisspellings(const VisibleSelection& selection)
On 2016/08/02 at 01:36:37, Yosi_UTC9 wrote:
> OPTIONAL: What return |bool| is? Could you add a comment about return value?

The return value indicates whether the spelling is correct. However, it's no
longer used after the refactoring.

Changed it to |void|.

https://codereview.chromium.org/2199743003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:432: // This
function is called with a selection already expanded to word boundaries.
On 2016/08/02 at 01:36:37, Yosi_UTC9 wrote:
> nit: Please use |TODO(email): ...| format.

Done.

https://codereview.chromium.org/2199743003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:442: const
EphemeralRange range = selection.toNormalizedEphemeralRange();
On 2016/08/02 at 01:36:37, Yosi_UTC9 wrote:
> s/const EphemeralRange/const EphemeralRange&/ to avoid copy.

Done.

[commit-bot: I haz the power, 2016-08-02 03:15:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 03:15:45]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-08-02 04:30:15]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-08-02 04:30:16]

lgtm

[commit-bot: I haz the power, 2016-08-02 04:30:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 04:34:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 04:37:26]

Description was changed from

==========
Remove some grammar checking code from SpellChecker

This patch does:

1. Remove SpellChecker::markBadGrammar and all of its call sites

2. Absorb SpellChecker::markMisspellingsOrBadGrammar by
SpellChecker::markMisspellings for code simplification

BUG=619452
TEST=n/a; no visible change
==========

to

==========
Remove some grammar checking code from SpellChecker

This patch does:

1. Remove SpellChecker::markBadGrammar and all of its call sites

2. Absorb SpellChecker::markMisspellingsOrBadGrammar by
SpellChecker::markMisspellings for code simplification

BUG=619452
TEST=n/a; no visible change

Committed: https://crrev.com/9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2
Cr-Commit-Position: refs/heads/master@{#409137}
==========

[commit-bot: I haz the power, 2016-08-02 04:37:27]

Patchset 2 (id:??) landed as
https://crrev.com/9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2
Cr-Commit-Position: refs/heads/master@{#409137}