DescriptionReland of Further reduction of feature_compiler.py generated code (patchset #1 id:1 of https://codereview.chromium.org/2201653003/ )
Reason for revert:
Not this either
Original issue's description:
> Revert of Further reduction of feature_compiler.py generated code (patchset #5 id:80001 of https://codereview.chromium.org/2193693003/ )
>
> Reason for revert:
> Suspect for widespread Win7 NaCl failures starting with
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55503
>
> Wasn't r408782, r408787 or r408781
>
> Original issue's description:
> > Further reduction of feature_compiler.py generated code
> >
> > Use raw pointers instead of unique pointers to reduce size. See linked
> > bug for size details.
> >
> > BUG=631416
> >
> > Committed: https://crrev.com/2026cea7fa1b2146d7113dc31f2a2969d9ec58e3
> > Cr-Commit-Position: refs/heads/master@{#408788}
>
> TBR=rdevlin.cronin@chromium.org,dcheng@chromium.org,scottmg@chromium.org
> NOTRY=true
> NOTREECHECKS=true
> BUG=631416
>
> Committed: https://crrev.com/132a21ca3dedb4b2942737a3e947c772c81743aa
> Cr-Commit-Position: refs/heads/master@{#408917}
TBR=rdevlin.cronin@chromium.org,dcheng@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631416
Committed: https://crrev.com/0c18de0470b513e16ce2c283ff89452cb0c974d7
Cr-Commit-Position: refs/heads/master@{#408922}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|