Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2199683002: Reland of Further reduction of feature_compiler.py generated code (Closed)

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
Reviewers:
Devlin, dcheng, scottmg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@test-with-leiz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Further reduction of feature_compiler.py generated code (patchset #1 id:1 of https://codereview.chromium.org/2201653003/ ) Reason for revert: Not this either Original issue's description: > Revert of Further reduction of feature_compiler.py generated code (patchset #5 id:80001 of https://codereview.chromium.org/2193693003/ ) > > Reason for revert: > Suspect for widespread Win7 NaCl failures starting with > https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55503 > > Wasn't r408782, r408787 or r408781 > > Original issue's description: > > Further reduction of feature_compiler.py generated code > > > > Use raw pointers instead of unique pointers to reduce size. See linked > > bug for size details. > > > > BUG=631416 > > > > Committed: https://crrev.com/2026cea7fa1b2146d7113dc31f2a2969d9ec58e3 > > Cr-Commit-Position: refs/heads/master@{#408788} > > TBR=rdevlin.cronin@chromium.org,dcheng@chromium.org,scottmg@chromium.org > NOTRY=true > NOTREECHECKS=true > BUG=631416 > > Committed: https://crrev.com/132a21ca3dedb4b2942737a3e947c772c81743aa > Cr-Commit-Position: refs/heads/master@{#408917} TBR=rdevlin.cronin@chromium.org,dcheng@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631416 Committed: https://crrev.com/0c18de0470b513e16ce2c283ff89452cb0c974d7 Cr-Commit-Position: refs/heads/master@{#408922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -41 lines) Patch
M extensions/common/features/base_feature_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/features/base_feature_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/features/complex_feature.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/features/complex_feature.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/common/features/complex_feature_unittest.cc View 6 chunks +8 lines, -12 lines 0 comments Download
M extensions/common/features/json_feature_provider.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M extensions/common/features/simple_feature_unittest.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M tools/json_schema_compiler/feature_compiler.py View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tapted
Created Reland of Further reduction of feature_compiler.py generated code
4 years, 4 months ago (2016-08-01 07:07:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199683002/1
4 years, 4 months ago (2016-08-01 07:07:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 07:09:52 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 07:11:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c18de0470b513e16ce2c283ff89452cb0c974d7
Cr-Commit-Position: refs/heads/master@{#408922}

Powered by Google App Engine
This is Rietveld 408576698