Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: src/builtins/builtins-callsite.cc

Issue 2199673002: Properly set function index in CallSite constructor (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-callsite.cc
diff --git a/src/builtins/builtins-callsite.cc b/src/builtins/builtins-callsite.cc
index 2038f28f680aa215f15d220e44dcc1f6849f2a7a..a5aaff44493b7998e70307aa6767e77cc3e94f71 100644
--- a/src/builtins/builtins-callsite.cc
+++ b/src/builtins/builtins-callsite.cc
@@ -64,7 +64,7 @@ BUILTIN(CallSiteConstructor) {
Handle<Object> fun_index;
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, fun_index,
Object::ToUint32(isolate, fun));
Yang 2016/08/01 09:11:46 I think having the integer conversion in the origi
jgruber 2016/08/01 12:04:23 Done.
- SET_CALLSITE_PROPERTY(obj, call_site_wasm_func_index_symbol, fun);
+ SET_CALLSITE_PROPERTY(obj, call_site_wasm_func_index_symbol, fun_index);
} else {
DCHECK(fun->IsJSFunction());
SET_CALLSITE_PROPERTY(obj, call_site_receiver_symbol, receiver);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698