Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2199633002: Revert of Pass per-frame task runners to Workers (when possible) (Closed)

Created:
4 years, 4 months ago by tzik
Modified:
4 years, 4 months ago
CC:
chromium-reviews, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass per-frame task runners to Workers (when possible) (patchset #5 id:100001 of https://codereview.chromium.org/2163983004/ ) Reason for revert: This CL seems to cause a test failure on "WebKit Linux Leak" bot. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21436 An example of the failure is: http/tests/serviceworker/foreign-fetch-workers.html ({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,15],"numberOfLiveResources":[0,1]}) Original issue's description: > Pass per-frame task runners to Workers (when possible) > > - For in-process workers (i.e. dedicated/compositor workers): always use > the associated document's task runners > - For out-of-process workers (i.e. service/shared workers): keep using the > default task runner of the main thread, but via TaskRunnerHelper so > we could still start using different task runners for different tasks > (e.g. loading vs timer) if we want. > > BUG=627034 > > Committed: https://crrev.com/66b07a326160fed57046fbb454f424a302d4cc6b > Cr-Commit-Position: refs/heads/master@{#408652} TBR=skyostil@chromium.org,hiroshige@chromium.org,haraken@chromium.org,nhiroki@chromium.org,kinuko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=627034 Committed: https://crrev.com/043b1d5eb0223ec6cf40afac5cb591112a5006d7 Cr-Commit-Position: refs/heads/master@{#408932}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : merge #

Messages

Total messages: 19 (10 generated)
tzik
Created Revert of Pass per-frame task runners to Workers (when possible)
4 years, 4 months ago (2016-08-01 05:24:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199633002/230001
4 years, 4 months ago (2016-08-01 05:27:16 UTC) #3
haraken
LGTM
4 years, 4 months ago (2016-08-01 05:29:05 UTC) #4
hiroshige
On 2016/08/01 05:29:05, haraken wrote: > LGTM dup of https://codereview.chromium.org/2196133002/ ?
4 years, 4 months ago (2016-08-01 05:32:30 UTC) #5
tzik
On 2016/08/01 05:32:30, hiroshige wrote: > On 2016/08/01 05:29:05, haraken wrote: > > LGTM > ...
4 years, 4 months ago (2016-08-01 05:36:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199633002/250001
4 years, 4 months ago (2016-08-01 07:47:57 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:250001)
4 years, 4 months ago (2016-08-01 08:58:51 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/043b1d5eb0223ec6cf40afac5cb591112a5006d7 Cr-Commit-Position: refs/heads/master@{#408932}
4 years, 4 months ago (2016-08-01 09:00:38 UTC) #18
kinuko
4 years, 4 months ago (2016-08-01 13:18:42 UTC) #19
Message was sent while issue was closed.
Thanks for reverting!

Powered by Google App Engine
This is Rietveld 408576698