Move Translate renderer messages to the Translate component

Move Translate renderer messages to the Translate component

BUG=335082
TBR=thakis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261683

[droger, 2014-04-01 20:05:01]

CC mad

[blundell, 2014-04-01 20:22:58]

LGTM

[droger, 2014-04-01 21:00:52]

+palmer as OWNER of ipc and render_messages

[palmer, 2014-04-01 22:36:12]

https://codereview.chromium.org/219963007/diff/20001/components/translate/con...
File components/translate/content/common/translate_messages.h (right):

https://codereview.chromium.org/219963007/diff/20001/components/translate/con...
components/translate/content/common/translate_messages.h:37: std::string, /* BCP
47/RFC 5646 language code the page
Does the recipient of these messages validate the string names (lexically and
for set membership in RFC 5646)?

It would be better to use a more strongly-typed value than a string for this,
such as an enum of all the RFC 5646 language codes.

https://codereview.chromium.org/219963007/diff/20001/components/translate/con...
components/translate/content/common/translate_messages.h:65: std::string        
  /* the original language */,
Same here as above, presumably.

[droger, 2014-04-02 08:16:10]

https://codereview.chromium.org/219963007/diff/20001/components/translate/con...
File components/translate/content/common/translate_messages.h (right):

https://codereview.chromium.org/219963007/diff/20001/components/translate/con...
components/translate/content/common/translate_messages.h:37: std::string, /* BCP
47/RFC 5646 language code the page
On 2014/04/01 22:36:13, Chromium Palmer wrote:
> Does the recipient of these messages validate the string names (lexically and
> for set membership in RFC 5646)?

I know languages are validated at some point (such as in
TranslateAcceptLanguages::IsAcceptLanguage), but it does not look like it is
done immediately after receiving the messages.

> 
> It would be better to use a more strongly-typed value than a string for this,
> such as an enum of all the RFC 5646 language codes.

Such a change would not belong to this CL (this CL is a simple code move). Is it
ok if I land this CL as is and file a separate bug to track this?

[droger, 2014-04-03 09:14:20]

palmer: ping

I filed http://crbug.com/359484 to track the issue you pointed out.

[palmer, 2014-04-03 19:06:06]

Thanks for filing the bug. IPC security LGTM for now.

[blundell, 2014-04-03 19:07:19]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-04-03 19:08:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/219963007/20001

[commit-bot: I haz the power, 2014-04-03 19:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 19:38:52]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[blundell, 2014-04-03 19:41:20]

TBR=thakis for changes to //chrome/browser/DEPS and //chrome/renderer/DEPS

[blundell, 2014-04-03 19:41:25]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-04-03 19:42:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/219963007/20001

[commit-bot: I haz the power, 2014-04-04 00:43:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-04 00:43:28]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[blundell, 2014-04-04 05:06:22]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-04-04 05:06:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/219963007/20001

[commit-bot: I haz the power, 2014-04-04 05:08:01]

Change committed as 261683