Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 219963002: Update SharedDeviveDisplay from ScreenOrientationListener. (Closed)

Created:
6 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update SharedDeviveDisplay from ScreenOrientationListener. Instead of having DeviceDisplayInfo listening for onConfigurationChange, this patch changes the update to come from ScreenOrientationListener. Ideally, we might want to have a DisplayListener that would be used by ScreenOrientationListener and would update a cached DeviceDisplayInfo. BUG=354275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260857

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java View 1 4 chunks +6 lines, -25 lines 0 comments Download
M ui/gfx/android/shared_device_display_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mlamouri (slow - plz ping)
6 years, 8 months ago (2014-03-31 20:42:56 UTC) #1
mlamouri (slow - plz ping)
6 years, 8 months ago (2014-03-31 20:43:39 UTC) #2
boliu
Thanks for splitting it up. lg2m but I have no owner powers here
6 years, 8 months ago (2014-03-31 20:53:02 UTC) #3
aelias_OOO_until_Jul13
lgtm. Adding tedchoc@ for other OWNERS
6 years, 8 months ago (2014-04-01 00:34:58 UTC) #4
Ted C
lgtm https://codereview.chromium.org/219963002/diff/1/ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java File ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java (right): https://codereview.chromium.org/219963002/diff/1/ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java#newcode29 ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java:29: private static DeviceDisplayInfo sInstance; I would remove one ...
6 years, 8 months ago (2014-04-01 00:47:56 UTC) #5
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 8 months ago (2014-04-01 10:16:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/219963002/20001
6 years, 8 months ago (2014-04-01 10:17:03 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 13:50:11 UTC) #8
Message was sent while issue was closed.
Change committed as 260857

Powered by Google App Engine
This is Rietveld 408576698