Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2199603002: Turn off syzygy_optimize by default when is_syzyasan is on. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn off syzygy_optimize by default when is_syzyasan is on. This correctly matches the GYP behavior. R=brettw@chromium.org, sebmarchand@chromium.org BUG=632563 Committed: https://crrev.com/5d766cbf65f353ba8ca480397193a2c7732f6d9c Cr-Commit-Position: refs/heads/master@{#408894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/compiler/compiler.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Dirk Pranke
4 years, 4 months ago (2016-07-31 22:00:41 UTC) #1
brettw
lgtm
4 years, 4 months ago (2016-07-31 23:23:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199603002/1
4 years, 4 months ago (2016-07-31 23:38:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-31 23:41:12 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-31 23:43:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d766cbf65f353ba8ca480397193a2c7732f6d9c
Cr-Commit-Position: refs/heads/master@{#408894}

Powered by Google App Engine
This is Rietveld 408576698