Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2199593003: Add kind to ConstantValue. (Closed)

Created:
4 years, 4 months ago by Johnni Winther
Modified:
4 years, 4 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add kind to ConstantValue. In preparation for testing deferred constants. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/b036a29cbfa0d105bddba26b98c71a1f1d5bacc0

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -12 lines) Patch
M pkg/compiler/lib/src/constants/values.dart View 1 18 chunks +52 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/constants.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 4 months ago (2016-08-01 12:08:23 UTC) #2
Harry Terkelsen
lgtm
4 years, 4 months ago (2016-08-01 16:45:25 UTC) #3
Johnni Winther
4 years, 4 months ago (2016-08-08 12:30:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b036a29cbfa0d105bddba26b98c71a1f1d5bacc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698