Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2199553002: Don't repeat header groups when one row of content doesn't fit on the first page (Closed)

Created:
4 years, 4 months ago by rhogan
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't repeat header groups when one row of content doesn't fit on the first page https://drafts.csswg.org/css-tables-3/#repeated-headers tells us that where there isn't 'enough space to insert at least one content row, users agents must drop the repeated header.' BUG=621258 Committed: https://crrev.com/b69173bcab740a91977294f1dc2f024b398cebf5 Cr-Commit-Position: refs/heads/master@{#409413}

Patch Set 1 #

Patch Set 2 : bug 621258 #

Total comments: 1

Messages

Total messages: 23 (15 generated)
rhogan
https://codereview.chromium.org/2199553002/diff/20001/third_party/WebKit/Source/core/layout/LayoutBox.cpp File third_party/WebKit/Source/core/layout/LayoutBox.cpp (left): https://codereview.chromium.org/2199553002/diff/20001/third_party/WebKit/Source/core/layout/LayoutBox.cpp#oldcode4893 third_party/WebKit/Source/core/layout/LayoutBox.cpp:4893: LayoutUnit pageLogicalHeight = layoutView->layoutState()->pageLogicalHeight(); Per https://chromium.googlesource.com/chromium/src/+blame/master/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp#249, this use of ...
4 years, 4 months ago (2016-08-02 17:59:02 UTC) #11
eae
LGTM
4 years, 4 months ago (2016-08-02 18:23:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199553002/20001
4 years, 4 months ago (2016-08-02 18:26:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199553002/20001
4 years, 4 months ago (2016-08-02 18:31:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/266086)
4 years, 4 months ago (2016-08-02 20:04:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199553002/20001
4 years, 4 months ago (2016-08-02 21:55:55 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 01:13:42 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 01:14:52 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b69173bcab740a91977294f1dc2f024b398cebf5
Cr-Commit-Position: refs/heads/master@{#409413}

Powered by Google App Engine
This is Rietveld 408576698