Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2199523002: Convert WebRange to be a simple pair of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot the exports. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget.cc ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index 495350bcf9f09df2c0cce732484252a2f4253915..d33b04560a36aa7349e98ae0662f34de51d964bb 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -899,10 +899,9 @@ bool WebFrameWidgetImpl::getCompositionCharacterBounds(WebVector<WebRect>& bound
void WebFrameWidgetImpl::applyReplacementRange(int start, int length)
{
if (LocalFrame* frame = focusedLocalFrameInWidget()) {
- WebLocalFrameImpl* webLocalFrame = WebLocalFrameImpl::fromFrame(frame);
- WebRange webrange = WebRange::fromDocumentRange(webLocalFrame, start, length);
- if (!webrange.isNull())
- webLocalFrame->selectRange(webrange);
+ // TODO(dglazkov): Going from LocalFrame to WebLocalFrameImpl seems
+ // silly. What is going on here?
+ WebLocalFrameImpl::fromFrame(frame)->selectRange(WebRange(start, length));
}
}
« no previous file with comments | « content/renderer/render_widget.cc ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698