Chromium Code Reviews| Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp |
| diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp |
| index 495350bcf9f09df2c0cce732484252a2f4253915..d33b04560a36aa7349e98ae0662f34de51d964bb 100644 |
| --- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp |
| +++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp |
| @@ -899,10 +899,9 @@ bool WebFrameWidgetImpl::getCompositionCharacterBounds(WebVector<WebRect>& bound |
| void WebFrameWidgetImpl::applyReplacementRange(int start, int length) |
| { |
| if (LocalFrame* frame = focusedLocalFrameInWidget()) { |
| - WebLocalFrameImpl* webLocalFrame = WebLocalFrameImpl::fromFrame(frame); |
| - WebRange webrange = WebRange::fromDocumentRange(webLocalFrame, start, length); |
| - if (!webrange.isNull()) |
| - webLocalFrame->selectRange(webrange); |
| + // TODO(dglazkov): Going from LocalFrame to WebLocalFrameImpl seems |
| + // silly. What is going on here? |
|
esprehn
2016/08/10 04:12:06
yeah seems like some bad layering
|
| + WebLocalFrameImpl::fromFrame(frame)->selectRange(WebRange(start, length)); |
| } |
| } |