libFuzzer for blink::MHTMLParser

third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

Index: third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
diff --git a/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h b/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
index bc5b15b42161526deab638629d44185f93e9e156..c6012835a129a2fa92ea6ec7d133072c5fac91d9 100644
--- a/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
+++ b/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
@@ -116,6 +116,22 @@ protected:
     std::unique_ptr<TestingPlatformMockWebThread> m_mockWebThread;
 };
 
+class ScopedUnittestsEnvironmentSetup {
+    WTF_MAKE_NONCOPYABLE(ScopedUnittestsEnvironmentSetup);
+public:
+    enum class TestType {
+        UnitTests,
+        LibFuzzer,

[esprehn, 2016/08/04 04:37:53]

I'd rather not do this, what code are you trying to share here? Why do we need a
separate setup?

[Łukasz Anforowicz, 2016/08/04 17:37:30]

I am trying to 1) consolidate all one-time test setup into
ScopedUnittestsEnvironmentSetup, 2) avoid i18n/ICU initialization from
MHTMLFuzzer.cpp (i.e. I want to limit base/i18n dependency to platform/testing
directory).
We don't in the latest patchset - separate setup has been avoided by
introduction of InitializeICUForTesting in base/test/icu_test_util.h (and
described in a reply to your other feedback).

+    };
+
+    ScopedUnittestsEnvironmentSetup(int argc, char** argv, TestType);
+    ~ScopedUnittestsEnvironmentSetup();
+
+private:
+    class Impl;

[esprehn, 2016/08/04 04:37:53]

Why do you need the nested class? Maybe you want DEFINE_STATIC_LOCAL for your
static to avoid the destructors?

[Łukasz Anforowicz, 2016/08/04 17:37:30]

I wanted to avoid including base/ headers from TestingPlatformSupport.h (i.e.
limit including base/headers to TestingPlatformSupport.cpp).  This was before I
realized that most of the base classes will be wrapped in std::unique_ptr (and
therefore can be forward declared).  Still - there are some base objects
embedded in the Impl class - I think it is desirable to keep them there.

WDYT?
Hmmm... maybe.  Without the destructors (i.e. when used as a *static* variable),
RunAllTests.cpp behavior would change (i.e. no cleanup from ~Impl would happen).

+    std::unique_ptr<Impl> m_impl;
+};
+
 } // namespace blink
 
 #endif // TestingPlatformSupport_h