Issue 2199473002: Fix analyzer error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2199473002: Fix analyzer error (Closed)

Created:
4 years, 4 months ago by vsm

Modified:
4 years, 4 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix analyzer error This is breaking travis. TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/5d436cee38134c2c3ad9db196ba2a727938adf82

Patch Set 1 #

Total comments: 1

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -9 lines)			Patch
M	lib/src/compiler/compiler.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pubspec.lock	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/codegen_expected/language/cyclic_import_test.js	View	2 chunks	+15 lines, -7 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

https://codereview.chromium.org/2199473002/diff/1/test/codegen_expected/language/cyclic_import_test.js File test/codegen_expected/language/cyclic_import_test.js (right): https://codereview.chromium.org/2199473002/diff/1/test/codegen_expected/language/cyclic_import_test.js#newcode280 test/codegen_expected/language/cyclic_import_test.js:280: const cyclic_import_test$133 = Object.create(null); Not sure why this file ...

4 years, 4 months ago (2016-07-29 21:31:36 UTC) #1

vsm

Committed patchset #1 (id:1) manually as 5d436cee38134c2c3ad9db196ba2a727938adf82 (presubmit successful).

4 years, 4 months ago (2016-07-29 21:31:56 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages