Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2199443002: Move PageLoadTiming TimeDelta fields to a common header. (Closed)

Created:
4 years, 4 months ago by Bryan McQuade
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PageLoadTiming TimeDelta fields to a common header. BUG=

Patch Set 1 #

Patch Set 2 : remove dom_loading #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -69 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/page_load_metrics/page_load_timing.h View 1 1 chunk +8 lines, -47 lines 0 comments Download
M chrome/common/page_load_metrics/page_load_timing.cc View 1 1 chunk +15 lines, -22 lines 0 comments Download
A chrome/common/page_load_metrics/page_load_timing_fields.h View 1 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/common/page_load_metrics/page_load_timing_unittest.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-07-29 19:04:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199443002/1
4 years, 4 months ago (2016-07-29 19:04:54 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-07-29 19:50:11 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 4 months ago (2016-07-29 19:50:12 UTC) #4
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-01 22:51:40 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199443002/20001
4 years, 4 months ago (2016-08-01 22:52:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-01 23:02:48 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 23:02:49 UTC) #8 
Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

Powered by Google App Engine
This is Rietveld 408576698