Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3977)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2199393002: Android: Make the spare renderer accessible to all Chrome tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 71313304b525e0377897de69f8c8604e1775f89e..e1969e7eeac8dfe7ea7ee1bb21e96c4d6fca2dc5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -52,6 +52,7 @@ import org.chromium.chrome.browser.SwipeRefreshHandler;
import org.chromium.chrome.browser.TabState;
import org.chromium.chrome.browser.TabState.WebContentsState;
import org.chromium.chrome.browser.UrlConstants;
+import org.chromium.chrome.browser.WarmupManager;
import org.chromium.chrome.browser.WebContentsFactory;
import org.chromium.chrome.browser.banners.AppBannerManager;
import org.chromium.chrome.browser.bookmarks.BookmarkUtils;
@@ -1461,7 +1462,12 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
boolean creatingWebContents = webContents == null;
if (creatingWebContents) {
- webContents = WebContentsFactory.createWebContents(isIncognito(), initiallyHidden);
+ webContents = WarmupManager.getInstance().takeSpareWebContents(
+ isIncognito(), initiallyHidden);
+ if (webContents == null) {
+ webContents =
+ WebContentsFactory.createWebContents(isIncognito(), initiallyHidden);
+ }
}
ContentViewCore contentViewCore = ContentViewCore.fromWebContents(webContents);

Powered by Google App Engine
This is Rietveld 408576698