[tools/perf] Add unittests coverage for system health benchmarks

tools/perf/benchmarks/system_health.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from core import perf_benchmark
 from telemetry import benchmark
 from telemetry.timeline import chrome_trace_category_filter
 from telemetry.web_perf import timeline_based_measurement
 import page_sets
 
 
 # See tr.v.Numeric.getSummarizedScalarNumericsWithNames()
 # https://github.com/catapult-project/catapult/blob/master/tracing/tracing/value/numeric.html#L323
 _IGNORED_STATS_RE = re.compile(r'_(std|count|max|min|sum|pct_\d{4}(_\d+)?)$')
 
 
-class _SystemHealthBenchmark(perf_benchmark.PerfBenchmark):

[nednguyen, 2016/08/02 19:21:49]

Remove these because the benchmarks are disabled & they don't follow system
health benchmarks' convention.

[petrcermak, 2016/08/03 08:49:27]

Acknowledged.

-  TRACING_CATEGORIES = [
-    'benchmark',
-    'navigation',
-    'blink.user_timing',
-  ]
-
-  def CreateTimelineBasedMeasurementOptions(self):
-    options = timeline_based_measurement.Options()
-    options.config.chrome_trace_config.SetCategoryFilter(
-        chrome_trace_category_filter.ChromeTraceCategoryFilter(','.join(
-            self.TRACING_CATEGORIES)))
-    options.SetTimelineBasedMetrics(['systemHealthMetrics'])
-    return options
-
-  @classmethod
-  def ShouldDisable(cls, browser):
-    # http://crbug.com/600463
-    galaxy_s5_type_name = 'SM-G900H'
-    return browser.platform.GetDeviceTypeName() == galaxy_s5_type_name
-
-
-@benchmark.Disabled('all')  # crbug.com/613050
-class SystemHealthTop25(_SystemHealthBenchmark):
-  page_set = page_sets.Top25PageSet
-
-  @classmethod
-  def Name(cls):
-    return 'system_health.top25'
-
-
-@benchmark.Disabled('android')  # crbug.com/601953
-@benchmark.Disabled('all')  # crbug.com/613050
-class SystemHealthKeyMobileSites(_SystemHealthBenchmark):
-  page_set = page_sets.KeyMobileSitesPageSet
-
-  @classmethod
-  def Name(cls):
-    return 'system_health.key_mobile_sites'
-
-
 class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):
   """Chrome Memory System Health Benchmark.
 
   https://goo.gl/Jek2NL.
   """
 
   def SetExtraBrowserOptions(self, options):
     options.AppendExtraBrowserArgs([
         # TODO(perezju): Temporary workaround to disable periodic memory dumps.
         # See: http://crbug.com/513692
@@ skipping 71 matching lines @@
     options.config.atrace_config.app_name = 'org.chromium.webview_shell'
     return options
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True
 
   @classmethod
   def Name(cls):
     return 'system_health.webview_startup'