Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2199333002:
Fix an OOB read through CallSite.GetFunctionName (Closed)
DescriptionFix an OOB read through CallSite.GetFunctionName
The func_index parameter passed to GetWasmFunctionNameFromTable can be
user-controlled through the CallSite constructor. Catch out-of-bounds
reads and return null as the function name in such cases.
This applies to the 5.3 branch and will be reverted on TOT in a bit.
BUG=632965
Committed: https://crrev.com/8592c450a68581d7257c1b2002983c0092cd749a
Cr-Commit-Position: refs/heads/master@{#38276}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jgruber@chromium.org changed reviewers: + yangguo@chromium.org
This is for fixing the issue in beta. We can revert this after it's been merged onto 5.3.
Description was changed from ========== Fix an OOB read through CallSite.GetFunctionName The func_index parameter passed to GetWasmFunctionNameFromTable can be user-controlled through the CallSite constructor. Catch out-of-bounds reads and return null as the function name in such cases. BUG=632965 ========== to ========== Fix an OOB read through CallSite.GetFunctionName The func_index parameter passed to GetWasmFunctionNameFromTable can be user-controlled through the CallSite constructor. Catch out-of-bounds reads and return null as the function name in such cases. This applies to the 5.3 branch and will be reverted on TOT in a bit. BUG=632965 ==========
On 2016/08/03 06:53:19, jgruber wrote: > This is for fixing the issue in beta. We can revert this after it's been merged > onto 5.3. LGTM.
jgruber@chromium.org changed reviewers: + ahaas@chromium.org
lgtm
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix an OOB read through CallSite.GetFunctionName The func_index parameter passed to GetWasmFunctionNameFromTable can be user-controlled through the CallSite constructor. Catch out-of-bounds reads and return null as the function name in such cases. This applies to the 5.3 branch and will be reverted on TOT in a bit. BUG=632965 ========== to ========== Fix an OOB read through CallSite.GetFunctionName The func_index parameter passed to GetWasmFunctionNameFromTable can be user-controlled through the CallSite constructor. Catch out-of-bounds reads and return null as the function name in such cases. This applies to the 5.3 branch and will be reverted on TOT in a bit. BUG=632965 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix an OOB read through CallSite.GetFunctionName The func_index parameter passed to GetWasmFunctionNameFromTable can be user-controlled through the CallSite constructor. Catch out-of-bounds reads and return null as the function name in such cases. This applies to the 5.3 branch and will be reverted on TOT in a bit. BUG=632965 ========== to ========== Fix an OOB read through CallSite.GetFunctionName The func_index parameter passed to GetWasmFunctionNameFromTable can be user-controlled through the CallSite constructor. Catch out-of-bounds reads and return null as the function name in such cases. This applies to the 5.3 branch and will be reverted on TOT in a bit. BUG=632965 Committed: https://crrev.com/8592c450a68581d7257c1b2002983c0092cd749a Cr-Commit-Position: refs/heads/master@{#38276} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8592c450a68581d7257c1b2002983c0092cd749a Cr-Commit-Position: refs/heads/master@{#38276}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2225773002/ by jgruber@chromium.org. The reason for reverting is: We can revert this now that it's landed on 5.3.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
