Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219933002: Componentize AccountReconcilor. (Closed)

Created:
6 years, 8 months ago by blundell
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Componentize AccountReconcilor. This CL does the following: - Componentize SigninOAuthHelper - Replaces AccountReconcilor's calls to Profile with calls to SigninClient - Passes AccountReconcilor's dependencies in directly rather than having AccountReconcilor obtain them from factories via the Profile - Componentizes AccountReconcilor BUG=334196, 333999 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261422

Patch Set 1 #

Total comments: 2

Patch Set 2 : Response to review #

Patch Set 3 : Rebase #

Patch Set 4 : Fixes for ChromeOS and rebase #

Patch Set 5 : ChromeOS fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -1272 lines) Patch
D chrome/browser/signin/account_reconcilor.h View 1 chunk +0 lines, -246 lines 0 comments Download
D chrome/browser/signin/account_reconcilor.cc View 1 2 1 chunk +0 lines, -746 lines 0 comments Download
M chrome/browser/signin/account_reconcilor_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/account_reconcilor_factory.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 1 2 3 4 5 chunks +15 lines, -7 lines 0 comments Download
D chrome/browser/signin/signin_oauth_helper.h View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/signin/signin_oauth_helper.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M chrome/browser/signin/signin_tracker.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M components/signin.gypi View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
A + components/signin/core/browser/account_reconcilor.h View 1 2 3 9 chunks +25 lines, -19 lines 0 comments Download
A + components/signin/core/browser/account_reconcilor.cc View 1 2 3 32 chunks +78 lines, -101 lines 0 comments Download
A + components/signin/core/browser/signin_oauth_helper.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + components/signin/core/browser/signin_oauth_helper.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
blundell
Whoever gets to it first :). There's some noise in account_reconcilor.* because "git cl format" ...
6 years, 8 months ago (2014-03-31 20:21:22 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/219933002/diff/1/components/signin/core/browser/account_reconcilor.h File components/signin/core/browser/account_reconcilor.h (right): https://codereview.chromium.org/219933002/diff/1/components/signin/core/browser/account_reconcilor.h#newcode136 components/signin/core/browser/account_reconcilor.h:136: bool IsUserSignedIn(); I actually prefer the term "IsProfileConnected".
6 years, 8 months ago (2014-04-01 02:26:24 UTC) #2
blundell
https://codereview.chromium.org/219933002/diff/1/components/signin/core/browser/account_reconcilor.h File components/signin/core/browser/account_reconcilor.h (right): https://codereview.chromium.org/219933002/diff/1/components/signin/core/browser/account_reconcilor.h#newcode136 components/signin/core/browser/account_reconcilor.h:136: bool IsUserSignedIn(); On 2014/04/01 02:26:26, Roger Tawa wrote: > ...
6 years, 8 months ago (2014-04-01 20:40:00 UTC) #3
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-02 15:58:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/219933002/80001
6 years, 8 months ago (2014-04-02 15:59:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 18:43:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-02 18:43:27 UTC) #7
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-02 21:36:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/219933002/100001
6 years, 8 months ago (2014-04-02 21:37:01 UTC) #9
blundell
The CQ bit was unchecked by blundell@chromium.org
6 years, 8 months ago (2014-04-03 06:03:02 UTC) #10
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-03 06:03:13 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 07:06:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-03 07:06:01 UTC) #13
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-03 08:58:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/219933002/120001
6 years, 8 months ago (2014-04-03 08:59:03 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 12:41:47 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-03 12:41:47 UTC) #17
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-03 13:00:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/219933002/120001
6 years, 8 months ago (2014-04-03 13:01:11 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 14:59:09 UTC) #20
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 14:59:10 UTC) #21
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-03 15:01:33 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/219933002/120001
6 years, 8 months ago (2014-04-03 15:03:02 UTC) #23
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:48:18 UTC) #24
Message was sent while issue was closed. 
Change committed as 261422

Powered by Google App Engine
This is Rietveld 408576698