Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2199323003: [turbofan] Reduces x << y ^ x >>> (32 - y) to x ror (32 - y). (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reduces x << y ^ x >>> (32 - y) to x ror (32 - y). The MachineOperatorReducer was only reducing word32 expressions of the type x << y | x >>> (32 - y) (and variants) to the equivalent Word32Ror. This CL applies the same pattern-matching logic to Word32Xor. BUG= Committed: https://crrev.com/a86397d890d3caa01a947e2a6e71beb1f58e6e6b Committed: https://crrev.com/2db734df39a6a759b78ac1abb98d7e86ed8fba79 Cr-Original-Commit-Position: refs/heads/master@{#38284} Cr-Commit-Position: refs/heads/master@{#39757}

Patch Set 1 #

Patch Set 2 : Rebaselined. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -37 lines) Patch
M src/compiler/machine-operator-reducer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 3 chunks +38 lines, -26 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 1 chunk +38 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
epertoso
4 years, 4 months ago (2016-08-03 10:31:20 UTC) #3
Benedikt Meurer
Thanks, LGTM.
4 years, 4 months ago (2016-08-03 10:33:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199323003/1
4 years, 4 months ago (2016-08-03 10:37:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 10:56:14 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a86397d890d3caa01a947e2a6e71beb1f58e6e6b Cr-Commit-Position: refs/heads/master@{#38284}
4 years, 4 months ago (2016-08-03 10:58:17 UTC) #10
epertoso
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2230213002/ by epertoso@chromium.org. ...
4 years, 4 months ago (2016-08-10 12:14:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199323003/20001
4 years, 2 months ago (2016-09-27 09:47:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 10:15:26 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 10:15:51 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2db734df39a6a759b78ac1abb98d7e86ed8fba79
Cr-Commit-Position: refs/heads/master@{#39757}

Powered by Google App Engine
This is Rietveld 408576698