Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2199283002: [modules] Introduce new VariableLocation for module imports/exports. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/globals.h ('k') | src/parsing/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 78a3c694b7a1e6b38f121a8518d09e243a93d9f1..b4f03b73fd6e547c6d9ec15dbf90c4aa380dbf13 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -872,6 +872,8 @@ void BytecodeGenerator::VisitVariableDeclaration(VariableDeclaration* decl) {
.CallRuntime(Runtime::kDeclareEvalVar, name, 1);
break;
}
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}
@@ -909,7 +911,10 @@ void BytecodeGenerator::VisitFunctionDeclaration(FunctionDeclaration* decl) {
VisitForAccumulatorValue(decl->fun());
builder()->StoreAccumulatorInRegister(literal).CallRuntime(
Runtime::kDeclareEvalFunction, name, 2);
+ break;
}
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}
@@ -1904,6 +1909,8 @@ void BytecodeGenerator::VisitVariableLoad(Variable* variable,
execution_result()->SetResultInAccumulator();
break;
}
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}
@@ -2129,6 +2136,8 @@ void BytecodeGenerator::VisitVariableAssignment(Variable* variable,
builder()->StoreLookupSlot(variable->name(), language_mode());
break;
}
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}
« no previous file with comments | « src/globals.h ('k') | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698