Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2199283002: [modules] Introduce new VariableLocation for module imports/exports. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index f64c979126e78a06e8944cb93a0b28d9cb5b2497..7f2ce828e572b956c60bed2c54a78bcfb9ac8a9d 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -5765,6 +5765,9 @@ void HOptimizedGraphBuilder::VisitVariableProxy(VariableProxy* expr) {
case VariableLocation::LOOKUP:
return Bailout(kReferenceToAVariableWhichRequiresDynamicLookup);
+
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}
@@ -7007,6 +7010,9 @@ void HOptimizedGraphBuilder::HandleCompoundAssignment(Assignment* expr) {
case VariableLocation::LOOKUP:
return Bailout(kCompoundAssignmentToLookupSlot);
+
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
return ast_context()->ReturnValue(Pop());
@@ -7155,6 +7161,9 @@ void HOptimizedGraphBuilder::VisitAssignment(Assignment* expr) {
case VariableLocation::LOOKUP:
return Bailout(kAssignmentToLOOKUPVariable);
+
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
} else {
return Bailout(kInvalidLeftHandSideInAssignment);
@@ -10801,6 +10810,9 @@ void HOptimizedGraphBuilder::VisitCountOperation(CountOperation* expr) {
case VariableLocation::LOOKUP:
return Bailout(kLookupVariableInCountOperation);
+
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
Drop(returns_original_input ? 2 : 1);
@@ -12192,6 +12204,8 @@ void HOptimizedGraphBuilder::VisitVariableDeclaration(
break;
case VariableLocation::LOOKUP:
return Bailout(kUnsupportedLookupSlotInDeclaration);
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}
@@ -12233,6 +12247,8 @@ void HOptimizedGraphBuilder::VisitFunctionDeclaration(
}
case VariableLocation::LOOKUP:
return Bailout(kUnsupportedLookupSlotInDeclaration);
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698