Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2199283002: [modules] Introduce new VariableLocation for module imports/exports. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index 9fe36bcce89e84cd04dcffd116456cc75e224c38..15fbc22a4de373470b2b1a133a980d6c2a99cbc1 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -5767,6 +5767,9 @@ void HOptimizedGraphBuilder::VisitVariableProxy(VariableProxy* expr) {
case VariableLocation::LOOKUP:
return Bailout(kReferenceToAVariableWhichRequiresDynamicLookup);
+
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}
@@ -7009,6 +7012,9 @@ void HOptimizedGraphBuilder::HandleCompoundAssignment(Assignment* expr) {
case VariableLocation::LOOKUP:
return Bailout(kCompoundAssignmentToLookupSlot);
+
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
return ast_context()->ReturnValue(Pop());
@@ -7157,6 +7163,9 @@ void HOptimizedGraphBuilder::VisitAssignment(Assignment* expr) {
case VariableLocation::LOOKUP:
return Bailout(kAssignmentToLOOKUPVariable);
+
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
} else {
return Bailout(kInvalidLeftHandSideInAssignment);
@@ -10803,6 +10812,9 @@ void HOptimizedGraphBuilder::VisitCountOperation(CountOperation* expr) {
case VariableLocation::LOOKUP:
return Bailout(kLookupVariableInCountOperation);
+
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
Drop(returns_original_input ? 2 : 1);
@@ -12196,6 +12208,8 @@ void HOptimizedGraphBuilder::VisitVariableDeclaration(
break;
case VariableLocation::LOOKUP:
return Bailout(kUnsupportedLookupSlotInDeclaration);
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}
@@ -12237,6 +12251,8 @@ void HOptimizedGraphBuilder::VisitFunctionDeclaration(
}
case VariableLocation::LOOKUP:
return Bailout(kUnsupportedLookupSlotInDeclaration);
+ case VariableLocation::MODULE:
+ UNREACHABLE();
}
}

Powered by Google App Engine
This is Rietveld 408576698