Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2199263002: [turbofan] Use CheckMaps in JSGlobalObjectSpecialization. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use CheckMaps in JSGlobalObjectSpecialization. This is a simple cleanup to use the recently added CheckMaps operator instead of the hand-crafted map check sequence. R=epertoso@chromium.org Committed: https://crrev.com/6bd7bd4bc6f2aab6454331ce6feff1ff889de12d Cr-Commit-Position: refs/heads/master@{#38242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M src/compiler/js-global-object-specialization.cc View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-02 11:47:50 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-08-02 12:09:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199263002/1
4 years, 4 months ago (2016-08-02 12:11:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 12:13:25 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 12:15:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bd7bd4bc6f2aab6454331ce6feff1ff889de12d
Cr-Commit-Position: refs/heads/master@{#38242}

Powered by Google App Engine
This is Rietveld 408576698